Remove unneeded request for CUDA device link phase

[robertmaynard]

Now that we are using embedded JIT-LTO fragments there is no need for a offline device link phase, as it is now done at runtime on a per kernel basis ( nvJitLink ).

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 4282f746-7ca9-45d0-a527-7c198b169b51

📥 Commits

Reviewing files that changed from the base of the PR and between 0a85b6b and e72162d.

📒 Files selected for processing (1)

• cpp/CMakeLists.txt

💤 Files with no reviewable changes (1)

• cpp/CMakeLists.txt

---

📝 Walkthrough

Summary by CodeRabbit

• Chores
  • Updated compilation configuration to streamline the library build process.

Walkthrough

The pull request removes the CUDA_RESOLVE_DEVICE_SYMBOLS ON target property from both the cuvs shared library and cuvs_static static library configurations in CMakeLists.txt. No other build configuration, properties, or wiring are affected.

Changes

Build configuration update

Layer / File(s)	Summary
Remove CUDA device symbol resolution from library targets cpp/CMakeLists.txt	The CUDA_RESOLVE_DEVICE_SYMBOLS ON property line is deleted from the set_target_properties blocks for both the cuvs shared library and cuvs_static static library targets.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested labels

improvement

Suggested reviewers

• bdice

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: removing the CUDA_RESOLVE_DEVICE_SYMBOLS property, which is the offline device link phase request.
Description check	✅ Passed	The description clearly relates to the changeset by explaining why CUDA_RESOLVE_DEVICE_SYMBOLS is no longer needed, citing the use of embedded JIT-LTO fragments and runtime device linking.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

• Generate code and open pull requests
• Plan features and break down work
• Investigate incidents and troubleshoot customer tickets together
• Automate recurring tasks and respond to alerts with triggers
• Summarize progress and report instantly

Built for teams:

• Shared memory across your entire org—no repeating context
• Per-thread sandboxes to safely plan and execute work
• Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[KyleFromNVIDIA]

/merge