[DO NOT MERGE] Test CCCL update#2051
Conversation
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe change updates the SPDX copyright year in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Review rate limit: 9/10 reviews remaining, refill in 6 minutes. Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
cmake/rapids_config.cmake (1)
31-38:⚠️ Potential issue | 🔴 Critical | ⚡ Quick winAvoid hardcoding a personal fork and mutable branch in the default dependency path.
Line 31 and Line 32 force all builds to fetch
KyleFromNVIDIA/rapids-cmake@update-cccl, and Line 36 becomes effectively unreachable. This changes global dependency provenance and undermines reproducibility/supply-chain safety for normal builds.💡 Proposed fix
-set(rapids-cmake-repo KyleFromNVIDIA/rapids-cmake) -set(rapids-cmake-branch update-cccl) +if(NOT rapids-cmake-repo) + set(rapids-cmake-repo rapidsai/rapids-cmake) +endif() + +if(NOT rapids-cmake-branch) + set(rapids-cmake-branch "${_rapids_branch}") +endif() if(NOT rapids-cmake-version) set(rapids-cmake-version "${RAPIDS_VERSION_MAJOR_MINOR}") endif() -if(NOT rapids-cmake-branch) - set(rapids-cmake-branch "${_rapids_branch}") -endif()🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@cmake/rapids_config.cmake` around lines 31 - 38, The defaults unconditionally set rapids-cmake-repo and rapids-cmake-branch to a personal fork and mutable branch, making rapids-cmake-branch fallback unreachable; change this so you only assign defaults when the variables are not already set (use if(NOT rapids-cmake-repo) and if(NOT rapids-cmake-branch)) and point the default repo to the official upstream (e.g., rapids/rapids-cmake) and the default branch to the established project branch fallback (use _rapids_branch or RAPIDS_VERSION_MAJOR_MINOR as appropriate) instead of the personal "KyleFromNVIDIA/rapids-cmake" and "update-cccl" values so rapids-cmake-repo, rapids-cmake-branch, rapids-cmake-version, RAPIDS_VERSION_MAJOR_MINOR and _rapids_branch behave as true configurable defaults.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@cmake/rapids_config.cmake`:
- Around line 31-38: The defaults unconditionally set rapids-cmake-repo and
rapids-cmake-branch to a personal fork and mutable branch, making
rapids-cmake-branch fallback unreachable; change this so you only assign
defaults when the variables are not already set (use if(NOT rapids-cmake-repo)
and if(NOT rapids-cmake-branch)) and point the default repo to the official
upstream (e.g., rapids/rapids-cmake) and the default branch to the established
project branch fallback (use _rapids_branch or RAPIDS_VERSION_MAJOR_MINOR as
appropriate) instead of the personal "KyleFromNVIDIA/rapids-cmake" and
"update-cccl" values so rapids-cmake-repo, rapids-cmake-branch,
rapids-cmake-version, RAPIDS_VERSION_MAJOR_MINOR and _rapids_branch behave as
true configurable defaults.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 631d384f-a278-4bb8-99ee-78c75bbddab6
📒 Files selected for processing (1)
cmake/rapids_config.cmake
No description provided.