Forward-merge release/26.04 into main#1929
Merged
Merged
Conversation
This PR attempts to fix the hanging pytest issues we are seeing in CI. From my investigations there are two issues. One is the `test_cagra_ace_tiny_memory_limit_triggers_disk_mode` and `test_hnsw_ace_tiny_memory_limit_triggers_disk_mode` tests which I have seen locally to hang. ~~At the moment, I am skipping these pytests in CI.~~ **Update**: After testing here 20 times https://github.com/rapidsai/cuvs/actions/runs/23182916436?pr=1893, I don't think we need to skip these tests. Second is a memory out of bounds error in `device_matrix_view_from_host` , first revealed by compute-sanitizer. This is likely a HMM issue. I have added more specific checks in the constructor so a copy is used when necessary. See this CI run from my test PR where I run 10 times to ensure that CI works with these fixes. https://github.com/rapidsai/cuvs/actions/runs/23131230353 I also reran CI on that test PR again. So all the pytests were run 20 times. Authors: - Anupam (https://github.com/aamijar) Approvers: - Tarang Jain (https://github.com/tarang-jain) URL: #1924
Contributor
Author
|
SUCCESS - forward-merge complete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward-merge triggered by push to release/26.04 that creates a PR to keep main up-to-date. If this PR is unable to be immediately merged due to conflicts, it will remain open for the team to manually merge. See forward-merger docs for more info.