-
Notifications
You must be signed in to change notification settings - Fork 33
cumulative updates since 25.12 to align with cuML 26.06 #1019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
7e845df
96077ce
6d573b9
dc518ac
ba7f67e
3bed382
b2982ae
ab5a9cb
624ebcb
71c8197
67d2f01
4d7490b
7492b96
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| --- | ||
| name: update-rapids-version | ||
| description: Updates python code (e.g. internal api calls) so that tests pass after running in conda environment with updated rapids version. | ||
| --- | ||
|
|
||
| You will be running in an already activated conda environment with the update rapids dependencies. | ||
|
|
||
| Make necessary code changes in the `python` directory tree to get the following test script to complete without error: | ||
|
|
||
| ```bash | ||
| cd python && CUDA_VISIBLE_DEVICES=0 bash run_test.sh | ||
| ``` | ||
|
|
||
| 1. Fix any formatting errors reported by the script. | ||
| 2. Fix any type-checking errors reported. | ||
| 3. Fix all other pytest errors reported. | ||
| - Note that pytest phase runs through all tests before reporting any errors. This can take a while. | ||
| - Most failures will be due to changes to internal apis in cuML that we rely on. | ||
|
|
||
|
|
||
| Iterate on 1., 2., and 3. until script succeeeds. The script can take a while to complete. | ||
|
|
||
| For 3., when working on individual tests, especially if only a few are failing, it is faster to run only these tests via pytest directly, followed by a final full run. | ||
|
|
||
| You may search the source code in the directory `../cuml` for relevant internal api changes. The branch for the desired version is checked out. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| # | ||
| # Copyright (c) 2025, NVIDIA CORPORATION. | ||
| # Copyright (c) 2025-2026, NVIDIA CORPORATION. | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
|
|
@@ -47,6 +47,6 @@ RUN wget --quiet https://repo.anaconda.com/miniconda/Miniconda3-latest-Linux-x86 | |
| && conda config --set solver libmamba | ||
|
|
||
| # install cuML | ||
| ARG RAPIDS_VERSION=25.12 | ||
| RUN conda install -y -c rapidsai -c conda-forge -c nvidia cuml=$RAPIDS_VERSION cuvs=$RAPIDS_VERSION python=3.10 pylibraft=$RAPIDS_VERSION raft-dask=$RAPIDS_VERSION cuda-version=12.2 numpy~=1.0 \ | ||
| ARG RAPIDS_VERSION=26.06 | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
The channel was changed from Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time! |
||
| RUN conda install -y -c rapidsai -c conda-forge -c nvidia cuml=$RAPIDS_VERSION cuvs=$RAPIDS_VERSION python=3.11 pylibraft=$RAPIDS_VERSION raft-dask=$RAPIDS_VERSION cuda-version=12.2 numpy~=1.0 \ | ||
| && conda clean --all -f -y | ||
Uh oh!
There was an error while loading. Please reload this page.