Repository navigation
Conversation
Signed-off-by: Rahul Prabhu <raprabhu@nvidia.com>
Contributor
[Low impact] The PR appears safe to merge; the Python 3.8 collection issue is fixed. SummaryAdds Delta Lake 4.3 tests that compare CPU and GPU dynamic partition overwrite behavior.
Reviews (3) · Last reviewed commit: "Fix test import" · Reviewed by Greptile |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16610.
Description
Delta Lake 4.3 normalizes partition values when dynamic partition overwrite decides which files to remove, so equivalent but differently formatted values (timestamps, dates, decimals) match. The GPU Delta 4.3 write path already passes the new
AddFiles to Delta'stxn.filterFiles(Seq[AddFile]), which does the normalization, so no plugin code changes are needed. This PR adds integration tests showing the GPU matches the CPU.New tests in
delta_lake_write_test.pyrewrite the stored partition strings in the table logs, then run a DPO write on CPU and GPU:UTCandAmerica/Los_Angeles, with mixed timestamp spellings in one tableparsePartitionValues=false, where raw string comparison must match between CPU and GPUINSERT OVERWRITEon a table with two partition columns, including null bearing partitionsPerformance tests are not required because this change only adds regression tests and does not modify runtime code or the existing GPU write path.
Checklists
Documentation
Testing
(Please provide the names of the existing tests in the PR description.)
Performance