Add skipped-path coverage for skewed BHJ private optimizer [databricks] #15153
Draft
wjxiz1992 wants to merge 1 commit into
Draft
Add skipped-path coverage for skewed BHJ private optimizer [databricks] #15153wjxiz1992 wants to merge 1 commit into
wjxiz1992 wants to merge 1 commit into
Conversation
Signed-off-by: Allen Xu <allxu@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JaCoCo sql-plugin line coverage: not measurable locally (Python private-optimizer IT/docs only; full run requires private optimizer Databricks runtime)
Contributes to #15136.
Summary
This follows up on the Databricks-wide skip for the skewed BHJ private-optimizer marker test by adding explicit skipped-path coverage:
assert_rule_skippedfor runtime-specific no-op paths where the rule should not produce its markercoalesced and skewedis absent while OFF-CPU and ON-GPU results still matchRationale
The skewed BHJ marker test proves the rule fires by requiring
coalesced and skewedin the ON physical plan. That is the wrong expectation for Databricks executor-broadcast AQE shapes, where the materialized shuffle can appear on the BHJ build side and the streamed-side skew marker is not stable.The new Databricks-only test records the intended fallback behavior separately instead of making the positive marker test Databricks-aware.
Testing
git diff --checkpython3 -m py_compile integration_tests/src/main/python/private_optimizer_common.py integration_tests/src/main/python/private_optimizer_skewed_bhj_join_test.pyNot run locally: full
private_optimizerPySpark IT requires a RAPIDS/private optimizer runtime. A direct local pytest collection attempt initialized Spark and failed before collection because the local Spark classpath did not includecom.nvidia.spark.SQLPlugin.Documentation
Testing
(Please provide the names of the existing tests in the PR description.)
Performance