Add Spark 4.0.3 shim support#15151
Open
firestarman wants to merge 2 commits into
Open
Conversation
Signed-off-by: Firestarman <firestarmanllc@gmail.com>
Contributor
|
Too many files changed for review. ( |
Collaborator
Author
|
build |
res-life
reviewed
Jun 26, 2026
| {"spark": "412"} | ||
| spark-rapids-shim-json-lines ***/ | ||
| package com.nvidia.spark.rapids.shims.spark412 | ||
| package com.nvidia.spark.rapids.shims |
Collaborator
There was a problem hiding this comment.
Adjacent to this changed hunk, the private vals below are named Log2 and Epsilon. Could you rename them to lowerCamelCase (log2, epsilon) and update their call sites? The repo style expects member vals to use camelCase.
Collaborator
Author
There was a problem hiding this comment.
nice catch, updated
res-life
reviewed
Jun 26, 2026
Comment on lines
34
to
35
Collaborator
There was a problem hiding this comment.
NIT:
Log2 => log2
Epsilon => epsilon
Collaborator
Author
There was a problem hiding this comment.
good suggestion, updated
Signed-off-by: Firestarman <firestarmanllc@gmail.com>
Collaborator
Author
|
build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15065.
Description
SPARK_HOME=/bigdata/work/tools/spark-4.0.3-bin-hadoop3 mvn -B -s /home/liangcail/.m2/settings_art.xml -f scala2.13/pom.xml -Dbuildver=403 -Dcuda.version=cuda13 verify: BUILD SUCCESS; integration tests reported 35271 passed, 2058 skipped, 513 xfailed, 895 xpassed; Scala tests reported 1759 succeeded, 0 failed./bigdata/tpcds_data/parquet_100frapids-4-spark_2.13-26.08.0-SNAPSHOT-cuda13-403-perf.jar/bigdata/work/tools/spark-4.0.2-bin-hadoop3/bigdata/work/tools/spark-4.0.3-bin-hadoop3Checklists
Documentation
Testing
(Please provide the names of the existing tests in the PR description.)
Performance