Enable license header check for Skills [skip ci]#15148
Conversation
Signed-off-by: YanxuanLiu <yanxuanl@nvidia.com>
Signed-off-by: YanxuanLiu <yanxuanl@nvidia.com>
|
build |
Greptile SummaryThis PR enables the license-header-check CI workflow to cover files under the
Confidence Score: 3/5The workflow change introduces a license check that will immediately fail for files that are not excluded but lack recognized copyright comment headers. The .github/workflows/license-header-check.yml — the exclusion list needs to cover Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[PR opened / synchronized] --> B[license-header-check workflow]
B --> C{File in included_file_patterns?}
C -- "*.yml, *.sh, *.java, *.scala, *.cpp, etc." --> D{Also in excluded_file_patterns?}
C -- "skills/**" --> D
D -- "skills/README.md\nskills/.gitignore\nskills/docs/**" --> E[Skip file ✓]
D -- Not excluded --> F{Has recognized license header?}
F -- "SPDX comment / Apache header" --> G[Pass ✓]
F -- "YAML front matter only\n(SKILL.md files)\nor no header (jvm.config)" --> H[FAIL ✗]
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
A[PR opened / synchronized] --> B[license-header-check workflow]
B --> C{File in included_file_patterns?}
C -- "*.yml, *.sh, *.java, *.scala, *.cpp, etc." --> D{Also in excluded_file_patterns?}
C -- "skills/**" --> D
D -- "skills/README.md\nskills/.gitignore\nskills/docs/**" --> E[Skip file ✓]
D -- Not excluded --> F{Has recognized license header?}
F -- "SPDX comment / Apache header" --> G[Pass ✓]
F -- "YAML front matter only\n(SKILL.md files)\nor no header (jvm.config)" --> H[FAIL ✗]
Reviews (3): Last reviewed commit: "exclude files" | Re-trigger Greptile |
There was a problem hiding this comment.
Pull request overview
Enables the repository’s license-header-check GitHub Actions workflow to include the “skills” content, aligning CI enforcement with Issue #15112’s request to keep skill license/SPDX header years up to date when those files change.
Changes:
- Extend the workflow’s
included_file_patternsto cover files underskills/.
| *.java, | ||
| *.fbs | ||
| *.fbs, | ||
| skills/* |
There was a problem hiding this comment.
| skills/* | |
| skills/udf-*/** |
We want everything, markdown and code, under skills to be checked, but not top-level things like skills/docs/dev or skills/README.md. We do want skills/examples/ and the upcoming skills/test/ covered, but those should already be covered under the existing extension patterns.
There was a problem hiding this comment.
Only README.md and VERSIONS.md should be excluded, right?
There was a problem hiding this comment.
Now included all files under skills except skills/docs/** skills/README.md
There was a problem hiding this comment.
More files will be added, e.g. see #15131 which adds pyproject.toml.
Signed-off-by: YanxuanLiu <yanxuanl@nvidia.com>
Signed-off-by: YanxuanLiu <yanxuanl@nvidia.com>
Signed-off-by: YanxuanLiu <yanxuanl@nvidia.com>
|
build |
|
Thank you @YanxuanLiu !! |
Fixes #15112
Description
Enable license header check for Skills
Checklists
Documentation
Testing
(Please provide the names of the existing tests in the PR description.)
Performance