Skip to content

[codex] Check UDF skill markdown license headers #15129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
WilliamK112 wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[codex] Check UDF skill markdown license headers #15129

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/license-header-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ jobs:
*.xml,
*.properties,
*.scala,
skills/udf-*/*.md,

@greptile-apps greptile-apps Bot Jun 24, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Subdirectory markdown files are not matched by this pattern

skills/udf-*/*.md only matches files exactly one level deep inside each udf-* directory — a bare * does not cross path separators. Four existing markdown files (skills/udf-convert-to-cuda/references/JNI_CUDA_GUIDE.md, NATIVE_BUILD_ENV.md, skills/udf-convert-to-cudf/references/RAPIDS_UDF.md, skills/udf-optimize-cudf/references/OPTIMIZATION_PATTERNS.md) all happen to have headers already, so there is no immediate CI failure, but any future markdown file added under a references/ or other nested directory would silently escape the check. Using skills/udf-*/**/*.md would cover the full tree if that is the intent.

@greptile-apps greptile-apps Bot Jun 24, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 SKILL.md front-matter copyright may not satisfy the license-header action

The SKILL.md files (e.g. skills/udf-benchmark/SKILL.md) embed copyright only in YAML front matter under metadata.spdx-file-copyright-text, not in a comment block. Every non-SKILL markdown file under skills/udf-* (e.g. CUDF_MICROBENCHMARKS.md) uses an <!-- SPDX-FileCopyrightText: … --> HTML comment. If NVIDIA/spark-rapids-common/license-header-check looks for a comment-style header (as it does for .yml, .scala, .py, etc.), all seven SKILL.md files will fail the check the moment any of them is touched in a PR, potentially blocking unrelated work. Has the action been confirmed to accept the YAML front-matter format as a valid copyright declaration? Has the license-header-check action been confirmed (locally or via its source) to accept the metadata.spdx-file-copyright-text YAML front-matter field in SKILL.md files as a valid copyright header, or does it only recognise comment-block formats?

*.py,
build/*,
*.cpp,
Expand All @@ -58,4 +59,3 @@ jobs:
*target/*,
thirdparty/*,
sql-plugin/src/main/java/com/nvidia/spark/rapids/format/*