[codex] Reduce noisy RAPIDS test output#15128
Draft
WilliamK112 wants to merge 1 commit into
Draft
Conversation
Signed-off-by: WilliamK112 <164879897+WilliamK112@users.noreply.github.com>
Contributor
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reduces noisy unit-test output by removing direct println statements from RapidsTestsTrait.rapidsCheckExpression, while keeping the existing logInfo diagnostics so expression-evaluation details still flow through the standard logging system.
Changes:
- Removed
printlnfor scalar-parameter evaluation messages. - Removed
printlnfor vectorized-parameter evaluation messages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14786.
Description
This removes the direct stdout
printlncalls fromRapidsTestsTrait.rapidsCheckExpressionfor scalar and vectorized parameter evaluation. The existinglogInfocalls are left in place so diagnostics still go through the normal logging path without duplicating every expression evaluation on stdout during unit-test runs.Validation:
git diff --checkprintln(s"... is being evaluated with ... Parameter")remains inRapidsTestsTrait.scalamvn package -pl tests -am -Dbuildver=330 -DwildcardSuites="org.apache.spark.sql.rapids.suites.RapidsPredicateSuite" -Dtests="BinaryComparison consistency check" -Dmaven.scalastyle.skip=true -Drat.skip=true; stopped before tests because local Maven needed to download the 934 MBspark-rapids-jnisnapshot jar.Checklists
Documentation
Testing
(Existing coverage:
org.apache.spark.sql.rapids.suites.RapidsPredicateSuiteand other Spark 3.3 suites usingRapidsTestsTrait.)Performance