Skip to content

[codex] Reduce noisy RAPIDS test output#15128

Draft
WilliamK112 wants to merge 1 commit into
NVIDIA:mainfrom
WilliamK112:codex/reduce-noisy-rapids-test-output
Draft

[codex] Reduce noisy RAPIDS test output#15128
WilliamK112 wants to merge 1 commit into
NVIDIA:mainfrom
WilliamK112:codex/reduce-noisy-rapids-test-output

Conversation

@WilliamK112

Copy link
Copy Markdown

Fixes #14786.

Description

This removes the direct stdout println calls from RapidsTestsTrait.rapidsCheckExpression for scalar and vectorized parameter evaluation. The existing logInfo calls are left in place so diagnostics still go through the normal logging path without duplicating every expression evaluation on stdout during unit-test runs.

Validation:

  • git diff --check
  • Confirmed no matching println(s"... is being evaluated with ... Parameter") remains in RapidsTestsTrait.scala
  • Attempted mvn package -pl tests -am -Dbuildver=330 -DwildcardSuites="org.apache.spark.sql.rapids.suites.RapidsPredicateSuite" -Dtests="BinaryComparison consistency check" -Dmaven.scalastyle.skip=true -Drat.skip=true; stopped before tests because local Maven needed to download the 934 MB spark-rapids-jni snapshot jar.

Checklists

Documentation

  • Updated for new or modified user-facing features or behaviors
  • No user-facing change

Testing

  • Added or modified tests to cover new code paths
  • Covered by existing tests
    (Existing coverage: org.apache.spark.sql.rapids.suites.RapidsPredicateSuite and other Spark 3.3 suites using RapidsTestsTrait.)
  • Not required

Performance

  • Tests ran and results are added in the PR description
  • Issue filed with a link in the PR description
  • Not required

Signed-off-by: WilliamK112 <164879897+WilliamK112@users.noreply.github.com>
@greptile-apps

greptile-apps Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR removes two direct println calls from RapidsTestsTrait.rapidsCheckExpression that were duplicating the immediately preceding logInfo messages to stdout on every expression evaluation during unit-test runs. The logInfo lines are left intact, so diagnostic information continues to flow through the normal Spark/SLF4J logging path.

  • Removes println(s"$origExpr is being evaluated with Scalar Parameter") and the vectorized-parameter equivalent, silencing the noisy per-expression stdout output without losing any information that was not already captured by logInfo.

Confidence Score: 5/5

Safe to merge — the only change is removing two println calls that duplicated existing logInfo output; no logic, GPU resource handling, or test correctness is affected.

The change touches only a test-utility trait, deletes duplicate stdout noise, and leaves the logInfo diagnostics intact. There is a single shim copy of this file (spark330) and no other versions require the same fix. No production code, GPU allocations, or correctness logic is modified.

No files require special attention.

Important Files Changed

Filename Overview
tests/src/test/spark330/scala/org/apache/spark/sql/rapids/utils/RapidsTestsTrait.scala Removes two redundant println calls in rapidsCheckExpression; logInfo equivalents are retained, so diagnostic output is preserved through the normal logging channel.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[rapidsCheckExpression called] --> B{isQualifiedForVectorizedParams?}
    B -- No --> C[logInfo: Scalar Parameter]
    B -- Yes --> D[logInfo: Vectorized Parameter]
    C --> E[Transform BoundReference to Literal]
    D --> F[Build DataFrame from inputRow]
    E --> G[resultDF.collect]
    F --> G
    G --> H[Compare result to expected]
Loading
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
    A[rapidsCheckExpression called] --> B{isQualifiedForVectorizedParams?}
    B -- No --> C[logInfo: Scalar Parameter]
    B -- Yes --> D[logInfo: Vectorized Parameter]
    C --> E[Transform BoundReference to Literal]
    D --> F[Build DataFrame from inputRow]
    E --> G[resultDF.collect]
    F --> G
    G --> H[Compare result to expected]
Loading

Reviews (1): Last reviewed commit: "Reduce noisy RAPIDS test output" | Re-trigger Greptile

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reduces noisy unit-test output by removing direct println statements from RapidsTestsTrait.rapidsCheckExpression, while keeping the existing logInfo diagnostics so expression-evaluation details still flow through the standard logging system.

Changes:

  • Removed println for scalar-parameter evaluation messages.
  • Removed println for vectorized-parameter evaluation messages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Reduce noisy unit-test output from println/debug messages

3 participants