Add regression test for assert_equal row-count mismatch#15109
Open
WilliamK112 wants to merge 1 commit into
Open
Add regression test for assert_equal row-count mismatch#15109WilliamK112 wants to merge 1 commit into
WilliamK112 wants to merge 1 commit into
Conversation
Collaborator
|
Please rebase your branch first. |
amahussein
requested changes
Jun 22, 2026
amahussein
left a comment
Collaborator
There was a problem hiding this comment.
This PR targets wrong branch.
The target should be main branch.
Contributor
Signed-off-by: WilliamK112 <164879897+WilliamK112@users.noreply.github.com>
0fedab2 to
fe9cd74
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11305.
Description
This PR adds regression coverage for
assert_equalwhen tests compare scalar row counts instead of collected rows.The new tests exercise row counts produced through the integration test Spark session helpers:
assert_equalAssertionErrorinstead of masking it with a scalar diff-renderingTypeErrorThere is no production-code change.
Validation:
git diff --checkpython -m py_compile integration_tests/src/main/python/asserts_regression_test.pyTESTS="asserts_regression_test.py" TEST_PARALLEL=1 ./integration_tests/run_pyspark_from_build.shwas attempted locally, but this checkout cannot execute the integration harness becauseSPARK_HOMEis not set.Checklists
Documentation
Testing
(Please provide the names of the existing tests in the PR description.)
Performance