Move aggregate and shuffle stats to the columnar module#15047
Move aggregate and shuffle stats to the columnar module#15047gerashegalov wants to merge 1 commit into
Conversation
da19e3a to
bc92d8e
Compare
d922d5a to
b94b8e4
Compare
bc92d8e to
b758f91
Compare
b94b8e4 to
4e3e434
Compare
b758f91 to
68788a1
Compare
4e3e434 to
0a315f6
Compare
68788a1 to
cd3b1c4
Compare
b614cf0 to
413b5ee
Compare
cd3b1c4 to
3cbe182
Compare
413b5ee to
7a668b3
Compare
Signed-off-by: Gera Shegalov <gshegalov@nvidia.com>
596d45e to
767f014
Compare
7a668b3 to
1db64a9
Compare
Greptile SummaryThis is an intermediate layer in a stacked refactor that migrates aggregate and shuffle statistics value classes from Scala case classes in
Confidence Score: 4/5Safe to merge as part of the full stack; the Java value classes are faithful ports with no behavioral change. All eight new Java classes are straightforward read-only value types with no GPU memory allocation, no concurrency changes, and no altered business logic. The only noteworthy inconsistency is that
Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
subgraph sql-plugin-columnar [sql-plugin-columnar NEW Java classes]
AM[AggregateModeInfo]
AMX[AsyncMetrics]
TE[ThrottlingExecutorStats]
BR[BlockRange]
BW[BlockWithSize]
TS[TransactionStats]
JC[JoinCardinalityStats]
JO[JoinOptions]
BW --> BR
end
subgraph sql-plugin [sql-plugin Scala originals - removed in later layer]
AM2[AggregateModeInfo case class]
TE2[ThrottlingExecutorStats case class]
BR2[BlockRange case class]
BW2[BlockWithSize trait]
JC2[JoinCardinalityStats case class]
JO2[JoinOptions case class]
WBI[WindowedBlockIterator]
BW2 --> BR2
BR2 --> WBI
end
subgraph tests
WBIS[WindowedBlockIteratorSuite\nnew BlockRange - updated syntax]
end
sql-plugin-columnar --> sql-plugin
sql-plugin --> tests
Reviews (1): Last reviewed commit: "Add columnar aggregate and shuffle stat ..." | Re-trigger Greptile |
Related to #14834.
Description
This PR is one reviewable layer in the unshim stack introduced by #15025. It moves aggregate and shuffle stat value classes into the columnar helper module, completing the focused statistics-helper movement before caller updates.
Stack context
Testing and validation notes
Checklists
Documentation
Testing
(Covered by the validation notes in the PR description.)
Performance