Remove old Spark 3.5 shim sources

[gerashegalov]

Related to #14834.

Description

This PR is one reviewable layer in the unshim stack introduced by #15025. It removes old Spark 3.5 shim sources that are now provided by shared helpers or the new helper modules.

Stack context

• Stack introduction: Add default common unshim packaging flow #15025
• Previous layer: Remove old Spark 3.3.1 through 3.4 shim sources #15036
• Next layer: Remove old Spark 4 shim sources and update tests #15038

Testing and validation notes

• No standalone behavior change is intended in this layer. It is covered by the full-stack packaging/build validation described in Add default common unshim packaging flow #15025 and the existing tests for the affected subsystem.
• The full split stack was verified to be tree-equivalent to the pre-split stack top.

Checklists

Documentation

• Updated for new or modified user-facing features or behaviors
• No user-facing change

Testing

• Added or modified tests to cover new code paths
• Covered by existing tests
  (Covered by the validation notes in the PR description.)
• Not required

Performance

• Tests ran and results are added in the PR description
• Issue filed with a link in the PR description
• Not required

[greptile-apps]

Greptile Summary

This PR removes Spark 3.5 shim source files from sql-plugin that have been migrated to the new sql-plugin-shims helper module as part of the broader unshim-stack refactor (#15025). Two shared shim files (LegacyBehaviorPolicyShim, NullOutputStreamShim) are updated to drop external library dependencies and align with the existing spark330 inline implementations.

• Deletes SparkShimServiceProvider.scala for spark350–358 and spark350db143 from sql-plugin; identical copies now live in sql-plugin-shims.
• Removes SequenceSizeExceededLimitErrorBuilder.scala from sql-plugin/spark350db143; the canonical copy is in sql-plugin-shims/spark350db143 with the same shim-json coverage.
• Updates LegacyBehaviorPolicyShim and NullOutputStreamShim to use inline string literals / anonymous OutputStream instead of LegacyBehaviorPolicy enum and Apache Commons IO, matching the pre-existing spark330 pattern.

Confidence Score: 5/5

Safe to merge — all deleted files have verified counterparts in sql-plugin-shims with matching content, and the two in-place edits align spark350 with the pre-existing spark330 pattern.

Every SparkShimServiceProvider deleted from sql-plugin was confirmed present in sql-plugin-shims with identical logic. The SequenceSizeExceededLimitErrorBuilder has the same shim-json-lines version coverage in its new location. LegacyBehaviorPolicyShim and NullOutputStreamShim now use the same inline implementations that have been stable in spark330 for some time, removing external library references with no behavioral difference.

No files require special attention.

Important Files Changed

Filename	Overview
sql-plugin/src/main/spark350/scala/com/nvidia/spark/rapids/shims/LegacyBehaviorPolicyShim.scala	Replaces LegacyBehaviorPolicy enum references with inline string literals, aligning with the pre-existing spark330 implementation for binary deduplication.
sql-plugin/src/main/spark350/scala/com/nvidia/spark/rapids/shims/NullOutputStreamShim.scala	Replaces Apache Commons IO NullOutputStream with an inline anonymous OutputStream no-op, matching the spark330 implementation and removing the external dependency.
sql-plugin/src/main/spark350/scala/com/nvidia/spark/rapids/shims/spark350/SparkShimServiceProvider.scala	Deleted from sql-plugin; identical content now served by sql-plugin-shims/src/main/spark350.
sql-plugin/src/main/spark350db143/scala/com/nvidia/spark/rapids/shims/spark350db143/SparkShimServiceProvider.scala	Deleted from sql-plugin; identical content (including DB 14.3 matchesVersion logic) now served by sql-plugin-shims/src/main/spark350db143.
sql-plugin/src/main/spark350db143/scala/org/apache/spark/sql/rapids/shims/SequenceSizeExceededLimitErrorBuilder.scala	Deleted from sql-plugin; canonical copy with matching shim-json coverage lives in sql-plugin-shims/src/main/spark350db143.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    subgraph Before["Before (sql-plugin)"]
        A["spark350/SparkShimServiceProvider"]
        B["spark351/SparkShimServiceProvider"]
        C["spark352-358/SparkShimServiceProvider"]
        D["spark350db143/SparkShimServiceProvider"]
        E["spark350db143/SequenceSizeExceededLimitErrorBuilder"]
        F["spark350/LegacyBehaviorPolicyShim\n(uses LegacyBehaviorPolicy enum)"]
        G["spark350/NullOutputStreamShim\n(uses commons-io NullOutputStream)"]
    end

    subgraph After["After (sql-plugin-shims)"]
        H["spark350/SparkShimServiceProvider"]
        I["spark351/SparkShimServiceProvider"]
        J["spark352-358/SparkShimServiceProvider"]
        K["spark350db143/SparkShimServiceProvider"]
        L["spark350db143/SequenceSizeExceededLimitErrorBuilder"]
    end

    subgraph Updated["Updated in place (sql-plugin/spark350)"]
        M["LegacyBehaviorPolicyShim\n(inline string literals)"]
        N["NullOutputStreamShim\n(inline anonymous OutputStream)"]
    end

    A -->|moved| H
    B -->|moved| I
    C -->|moved| J
    D -->|moved| K
    E -->|moved| L
    F -->|aligned with spark330 pattern| M
    G -->|aligned with spark330 pattern| N

Loading

_{Reviews (1): Last reviewed commit: "Remove old Spark 3.5 shim sources" | Re-trigger Greptile}