Update UDF compiler for shared helper layout#15028
Conversation
3cf1779 to
c99cc88
Compare
6ebd35c to
f608c12
Compare
c99cc88 to
bc737d5
Compare
f608c12 to
f04280c
Compare
6f0d32e to
39664ac
Compare
2aad668 to
7918b20
Compare
12050e2 to
da7172c
Compare
9974576 to
bc3dcf9
Compare
d7cc002 to
58fd9d3
Compare
09556c1 to
951af07
Compare
58fd9d3 to
dd489ce
Compare
951af07 to
d0da6bd
Compare
dd489ce to
9a0fceb
Compare
d0da6bd to
9523c22
Compare
2d11a0d to
c9b6910
Compare
6a78825 to
389bcfb
Compare
c9b6910 to
38f68ad
Compare
389bcfb to
1c955c0
Compare
38f68ad to
42519c0
Compare
42519c0 to
a5a6171
Compare
57a7219 to
a1e022a
Compare
a5a6171 to
0681545
Compare
a1e022a to
fa4c038
Compare
8d38745 to
c2a810e
Compare
7c8095e to
c012546
Compare
c2a810e to
b83a78a
Compare
c012546 to
e9c90de
Compare
b83a78a to
97298e1
Compare
e9c90de to
afbcd10
Compare
97298e1 to
23b2e37
Compare
afbcd10 to
632eb14
Compare
07a37f3 to
f52fcdc
Compare
d630815 to
7c174ff
Compare
f52fcdc to
681d6a2
Compare
7c174ff to
85991fb
Compare
07130f5 to
3720055
Compare
85991fb to
2c95704
Compare
3720055 to
76c8964
Compare
Signed-off-by: Gera Shegalov <gshegalov@nvidia.com>
76c8964 to
f1ce3e8
Compare
2db9df3 to
e557937
Compare
Greptile SummaryThis PR adapts the UDF compiler module to the "shared helper layout" introduced by the unshim stack. The main changes remove the dependency on Spark's internal
Confidence Score: 5/5This PR is safe to merge — all changes are mechanical refactors with no logic mutations. The changes swap Spark's internal Logging trait for direct SLF4J calls, convert Cast/Encode companion-object apply to new construction (preserving all defaults), and convert one case class to a plain class that is only ever instantiated via reflection. All call sites have been verified, isDebugEnabled guards are correctly added, and the timeZoneId forwarding in CatalystExpressionBuilder.simplifyExpr is preserved unchanged. No files require special attention; both Scala 2.12 and 2.13 Instruction.scala variants are in sync. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[UDF Compiler Module] --> B[LogicalPlanRules\nclass - no-arg ctor]
B --> C[GpuScalaUDFLogical\ncase class + companion log]
C --> D[CatalystExpressionBuilder\ncase class + companion log]
D --> E[CFG / BB\ncase class + companion log]
D --> F[Instruction\ncase class + companion log]
D --> G[State]
subgraph Logging
H[Before: extends Logging\nSpark internal trait]
I[After: LoggerFactory.getLogger\nSLF4J direct - shared helper]
end
subgraph CastConstruction
J["Before: Cast(e, t)\ncompanion apply"]
K["After: new Cast(e, t, None)\ndirect constructor"]
end
B -.->|reflection| L[ShimLoader.newInstanceOf]
H --> I
J --> K
Reviews (1): Last reviewed commit: "Update UDF compiler for shared helper la..." | Re-trigger Greptile |
Related to #14834.
Description
This PR is one reviewable layer in the unshim stack introduced by #15025. It updates the UDF compiler and related documentation for the shared helper layout. This is the final follow-up layer on top of the unshim stack.
Stack context
Testing and validation notes
Checklists
Documentation
Testing
(Covered by the validation notes in the PR description.)
Performance