docs: clarify C++ test GPU memory requirements#4749
Draft
WilliamK112 wants to merge 1 commit into
Draft
Conversation
WilliamK112
force-pushed
the
codex/docs-cpp-test-gpu-memory
branch
from
9ab43fe to
9b39a9b
Compare
Signed-off-by: WilliamK112 <164879897+WilliamK112@users.noreply.github.com>
WilliamK112
force-pushed
the
codex/docs-cpp-test-gpu-memory
branch
from
ecfa3b3 to
e692f72
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2070.
This updates the C++ testing guidance in
CONTRIBUTING.mdto call out that the full C++ gtest suite needs enough free GPU memory for the largest row-conversion tests. In particular,RowToColumnTests.Biggestbuilds a 128-column by2 * 1024 * 1024rowINT32table, about 1 GiB before row-conversion output and temporary allocations, and is known to OOM on 6 GiB GPUs.The docs now suggest using a narrower gtest filter while iterating on smaller development GPUs and reserving larger-memory GPUs for full C++ suite validation.
Validation:
git diff --checksrc/main/cpp/tests/row_conversion.cpppre-commit: it is not installed in this environment, and thethirdparty/cudfsubmodule needed by the always-run clang-format-version hook is not initialized.This is a documentation-only change; no tests were changed.