Skip to content

[Part 2] [ORC-timezone]: Extract recurring DST rule from JVM timezone APIs #4635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
res-life merged 35 commits into from
Jun 5, 2026
Merged

[Part 2] [ORC-timezone]: Extract recurring DST rule from JVM timezone APIs #4635

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
9cf0865
Extract recurring DST rule for ORC timezone
May 27, 2026
ced11e0
Address review feedback for DST rule extraction
May 29, 2026
2f52184
Name DstRule mode and timeMode constants
May 29, 2026
26fad9a
Stop probing once both DST transitions are found
May 29, 2026
a4b1fe3
Derive wall-clock year using rawOffset + dstSavings
May 29, 2026
90c8863
Move DST rule extraction to OrcDstRuleExtractor
May 29, 2026
7708b14
Clamp DOW_IN_MONTH and DOW_LE_DOM rule-day computations
Jun 3, 2026
e0982d3
Fix stale Javadoc link after DST move
Jun 3, 2026
05a0eb8
Document extractDstRule @param and @return tags
Jun 3, 2026
2864e65
Lock full DstRule shape in London + Sydney tests
Jun 3, 2026
98c1665
Cover IllegalStateException path in extractDstRule
Jun 3, 2026
d43c5f0
Cover terminal "Failed to extract" exception in extractDstRule
Jun 3, 2026
5289276
Hoist dstStart/dstEnd computation in verifyDstRule
Jun 3, 2026
423ce1f
Cover four Path-A IllegalStateException branches
Jun 3, 2026
fbdde7e
Remove dead computeDstOffset entry point
Jun 3, 2026
3ff7936
Test hygiene + cover negative-day-indicator shape rejection
Jun 3, 2026
abcf275
Cover Path A success and TIME_MODE_UTC branch
Jun 3, 2026
8668c0b
Expand nthDayOfWeekUtcMs Javadoc with @param/@return
Jun 3, 2026
a9220de
Use consistent digit separator for milliseconds-per-hour literal
Jun 3, 2026
64d4acc
Cover Path A's verifyDstRuleAcrossReferenceYears failure branch
Jun 3, 2026
2ff4ef0
Document the unreachable computeRuleDay branches
Jun 3, 2026
49def41
Cover TIME_MODE_WALL via a Path A wall-time start rule
Jun 3, 2026
c584fc3
Import java.time.LocalDate in test file
Jun 3, 2026
0059fcc
Cover isMidnightEndOfDay branch in getTransitionRuleTimeMillis
Jun 3, 2026
c7292de
Document decodeTransition's binarySearchTransition precondition
Jun 3, 2026
beb158f
Normalize 3600 to 3_600 in getTransitionRuleTimeMillis
Jun 3, 2026
74cfba3
Test both-negative-delta case of identify-rules guard
Jun 3, 2026
fd33d7b
Test February day-of-month clamp in computeRuleDay
Jun 3, 2026
ef4dd08
Sanity-check tz and rules describe the same zone
Jun 3, 2026
a1dc9e5
Fix testExtractDstRuleFebruaryClampDoesNotThrow
Jun 3, 2026
7d391d9
Test extractDstRule's tz/rules sanity-check guard
Jun 3, 2026
8f97225
Make synthetic tz literally mirror computeRuleDay
Jun 3, 2026
f17d6fe
Document why UTC is safe in extractDstRuleFor's fixed-offset path
Jun 3, 2026
3c4216c
Test extractDstRuleByProbing's multiple-DST-on guard
Jun 3, 2026
3ea2a5a
Fix synthetic ZoneRules fixtures failing on the JDK 8 build target
Jun 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading