ORC tz split 1/6: JNI plumbing and OrcTimezoneContext skeleton#4545
Closed
res-life wants to merge 1 commit into
Closed
ORC tz split 1/6: JNI plumbing and OrcTimezoneContext skeleton#4545res-life wants to merge 1 commit into
res-life wants to merge 1 commit into
Conversation
Collaborator
|
NOTE: release/26.06 has been created from main. Please retarget your PR to release/26.06 if it should be included in the release. |
Collaborator
Author
|
build |
Part of the split of #4432 into smaller PRs for review. This PR brings in only the JNI surface and Java entrypoint changes: - src/main/cpp/src/GpuTimeZoneDBJni.cpp: new JNI methods for building/ releasing per-table ORC timezone context and the parse_dst_rule helper. - src/main/cpp/src/timezones.hpp: declarations for the new convert_orc_timezones path, OrcTimezoneInfo struct, and DST rule fields. - src/main/java/com/nvidia/spark/rapids/jni/GpuTimeZoneDB.java: OrcTimezoneContext class, convertOrcTimezones taking ColumnView, and wiring through the new native methods. - src/main/resources/orc_timezone_info.data: delete the pre-built data file (subsequent PRs replace it with runtime-generated metadata). The Java code references OrcTimezoneInfo.get(...) and DstRule which are introduced in the next PR (orc-tz-2-orctzinfo-dst-extract), so this intermediate branch does not compile on its own and is for review only. Signed-off-by: Chong Gao <chongg@nvidia.com>
91450ec to
b38def7
Compare
Collaborator
Author
|
build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the split of #4432 into smaller reviewable PRs (≤500 lines each).
Companion: NVIDIA/cudf-spark#14544
This PR brings in only the JNI surface and Java entrypoint changes:
The Java code references
OrcTimezoneInfo.get(...)andDstRulewhich are introduced in #orc-tz-2 (next PR in the chain), so this intermediate branch does not compile on its own and is for review only.Stack
Signed-off-by: Chong Gao chongg@nvidia.com