Fix bug: Update requirements and notebooks for DL examples #633
Conversation
Greptile SummaryThis PR fixes several bugs in TensorFlow deep-learning inference notebooks and tightens dependency pins across the shared requirements files. The core fixes address a
Confidence Score: 5/5Safe to merge — all changes are targeted bug fixes and dependency stabilization with no new logic paths that could regress existing behavior. The changes correct real bugs (data leakage from the wrong DataFrame reference in The two requirements files ( Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[vectorize_layer.adapt on train data] --> B[Train + evaluate model]
B --> C["normalize_vocabulary(get_vocabulary())\nFilters '' and '[UNK]', preserves order"]
C --> D[vectorize_layer.set_vocabulary]
D --> E[export_model.save → text_model.keras]
E --> F[Spark predict_batch_udf loads model]
D --> G["normalize_vocabulary again\n(idempotent on already-clean vocab)"]
G --> H[vectorize_layer.set_vocabulary]
H --> I[export_model.save → text_model_cleaned.keras]
I --> J[Triton server loads cleaned model]
style C fill:#d4edda,stroke:#28a745
style D fill:#d4edda,stroke:#28a745
style G fill:#fff3cd,stroke:#ffc107
style H fill:#fff3cd,stroke:#ffc107
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
A[vectorize_layer.adapt on train data] --> B[Train + evaluate model]
B --> C["normalize_vocabulary(get_vocabulary())\nFilters '' and '[UNK]', preserves order"]
C --> D[vectorize_layer.set_vocabulary]
D --> E[export_model.save → text_model.keras]
E --> F[Spark predict_batch_udf loads model]
D --> G["normalize_vocabulary again\n(idempotent on already-clean vocab)"]
G --> H[vectorize_layer.set_vocabulary]
H --> I[export_model.save → text_model_cleaned.keras]
I --> J[Triton server loads cleaned model]
style C fill:#d4edda,stroke:#28a745
style D fill:#d4edda,stroke:#28a745
style G fill:#fff3cd,stroke:#ffc107
style H fill:#fff3cd,stroke:#ffc107
Reviews (2): Last reviewed commit: "Update DL inference requirement headers" | Re-trigger Greptile |
Signed-off-by: YanxuanLiu <yanxuanl@nvidia.com>
Signed-off-by: YanxuanLiu <yanxuanl@nvidia.com>
Signed-off-by: YanxuanLiu <yanxuanl@nvidia.com>
Signed-off-by: YanxuanLiu <yanxuanl@nvidia.com>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> Signed-off-by: YanxuanLiu <yanxuanl@nvidia.com>
Signed-off-by: YanxuanLiu <yanxuanl@nvidia.com>
Signed-off-by: YanxuanLiu <yanxuanl@nvidia.com>
rishic3
left a comment
There was a problem hiding this comment.
Looks good, thanks @YanxuanLiu. On a broader note almost no one is writing any new Tensorflow, so we should consider deprecating the _tf notebooks.
Sure, will remove from our default notebook list |
Fix bug of requirements and notebooks for DL inference examples.