Update CMake to 4.0#627
Conversation
This commit updates CMakeLists.txt to use CMake 4.0+, and updates the Dockerfile used in the build. This is in line with the changes in cuDF, in rapidsai/cudf#22492. Signed-off-by: Tim Liu <timl@nvidia.com>
Greptile SummaryThis PR fixes a build failure caused by the upstream cuDF project now requiring CMake 4.0 or higher, updating both the Dockerfile and the project's own
Confidence Score: 5/5Safe to merge; both changes are mechanical version bumps that directly unblock the broken build. The two changes are a single-line version bump in the Dockerfile and a matching cmake_minimum_required update in CMakeLists.txt. Both track the upstream cuDF change and carry no functional risk. The only note is a stale inline comment, which is a cosmetic issue. No files require special attention; both changed files are straightforward build-configuration updates. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Docker build] -->|downloads| B["CMake 4.0.3 binary\n(was 3.30.4)"]
B --> C[Container image with CMake 4.0.3]
C --> D[Maven UDF native build]
D --> E["CMakeLists.txt\ncmake_minimum_required(VERSION 4.0)"]
E --> F{Fetch cuDF via CPM}
F -->|cuDF CMakeLists.txt requires CMake 4.0| G[✓ Version satisfied — build proceeds]
F -->|old CMake 3.30.4| H[✗ CMake Error: 4.0 or higher required]
Reviews (1): Last reviewed commit: "Update CMake to 4.0" | Re-trigger Greptile |
There was a problem hiding this comment.
Pull request overview
Updates the RAPIDS-accelerated UDF native build configuration to meet cuDF’s new requirement for CMake 4.0+, unblocking builds that currently fail due to running CMake 3.30.4.
Changes:
- Bump
cmake_minimum_requiredto CMake 4.0 in the native UDF CMake project. - Update the UDF build Dockerfile to install CMake 4.0.3.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| examples/UDF-Examples/RAPIDS-accelerated-UDFs/src/main/cpp/CMakeLists.txt | Raises the minimum required CMake version to 4.0 to align with cuDF requirements. |
| examples/UDF-Examples/RAPIDS-accelerated-UDFs/Dockerfile | Updates the pinned CMake version used in the build container to 4.0.3. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Thanks Tim to fix this. |
To fix build cuDF cmake version error
Refer to NVIDIA/cudf-spark-jni#4557
This commit updates CMakeLists.txt to use CMake 4.0+, and updates the Dockerfile used in the build.
This is in line with the changes in cuDF, in rapidsai/cudf#22492.