[Tensornet] Support trajectory simulation for unitary mixture noise channels #2520
Conversation
Signed-off-by: Thien Nguyen <[email protected]>
Signed-off-by: Thien Nguyen <[email protected]>
Signed-off-by: Thien Nguyen <[email protected]>
Signed-off-by: Thien Nguyen <[email protected]>
…jectory Signed-off-by: Thien Nguyen <[email protected]>
Signed-off-by: Thien Nguyen <[email protected]>
…nsornetStateCompute) The first one is only needed once for trajectory simulation. Signed-off-by: Thien Nguyen <[email protected]>
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
Signed-off-by: Thien Nguyen <[email protected]>
Signed-off-by: Thien Nguyen <[email protected]>
Signed-off-by: Thien Nguyen <[email protected]>
Signed-off-by: Thien Nguyen <[email protected]>
Signed-off-by: Thien Nguyen <[email protected]>
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
Signed-off-by: Thien Nguyen <[email protected]>
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
Signed-off-by: Thien Nguyen <[email protected]>
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
Signed-off-by: Thien Nguyen <[email protected]>
Signed-off-by: Thien Nguyen <[email protected]>
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
Signed-off-by: Thien Nguyen <[email protected]>
Signed-off-by: Thien Nguyen <[email protected]>
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
Signed-off-by: Thien Nguyen <[email protected]>
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
| return std::make_pair(probs, mats); | ||
| } | ||
|
|
||
| void SimulatorTensorNetBase::applyNoiseChannel( |
There was a problem hiding this comment.
This function seems super huge. Can we please modularize the code in it?
There was a problem hiding this comment.
Sure, refactored in 7542c74
| const std::vector<std::complex<double>> matPauliX{ | ||
| {0.0, 0.0}, {1.0, 0.0}, {1.0, 0.0}, {0.0, 0.0}}; | ||
| const std::vector<std::complex<double>> matPauliY{ | ||
| {0.0, 0.0}, {0.0, 1.0}, {0.0, -1.0}, {0.0, 0.0}}; |
There was a problem hiding this comment.
Shouldn't PauliY be {0.0, 0.0}, {0.0, -1.0}, {0.0, 1.0}, {0.0, 0.0}?
| @@ -153,6 +153,149 @@ class SimulatorMPS : public SimulatorTensorNetBase { | |||
| SimulatorTensorNetBase::applyExpPauli(theta, controls, qubitIds, op); | |||
| } | |||
|
|
|||
| /// @brief Sample a subset of qubits | |||
| cudaq::ExecutionResult sample(const std::vector<std::size_t> &measuredBits, | |||
There was a problem hiding this comment.
Let's modularize this function as well.
There was a problem hiding this comment.
Refactored in d0fc6e7
| return counts; | ||
| } | ||
|
|
||
| cudaq::observe_result observe(const cudaq::spin_op &ham) override { |
There was a problem hiding this comment.
Refactored in d0fc6e7
|
Once we modularize the long functions, can we please throw in some unittests? I will go through the PR again once we have the changes. |
1tnguyen
changed the title
Signed-off-by: Thien Nguyen <[email protected]>
Signed-off-by: Thien Nguyen <[email protected]>
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
Signed-off-by: Thien Nguyen <[email protected]>
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
Signed-off-by: Thien Nguyen <[email protected]>
Thanks. I added a new unit test for the matrix representation bug that is not detectable by |
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
Description
(1) Add support for
cutensornetStateApplyUnitaryChannelPerform trajectory-based simulation if there are noise ops applied to the state.
Throw error if seeing non-unitary noise ops.
MPS has a custom implementation (override) for trajectory sample/observe as it needs to recompute the state for each trajectory.
Enable noise tests for tensornet backends.
(2) Some minor updates to tensornet backends
Replace a couple of deprecating enums.
Make the number of hyper samples a configuration param and add the corresponding doc.