Checking vector size for a power of 2 #2491
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
1 similar comment
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
schweitzpgi
reviewed
Jan 2, 2025
python/utils/OpaqueArguments.h
Outdated
| @@ -99,6 +99,14 @@ inline py::args simplifiedValidateInputArguments(py::args &args) { | |||
| if (shape.size() != 1) | |||
| throw std::runtime_error("Cannot pass ndarray with shape != (N,)."); | |||
|
|
|||
| // Vector size validation | |||
| size_t size = shape[0].cast<size_t>(); | |||
| if (size == 0 || (size & (size - 1)) != 0) { | |||
There was a problem hiding this comment.
This check is only valid if the argument is used as an initializer (state) for a register of qubits. That is, we are allowed to pass a vector of any length of floats to a kernel in general.
Signed-off-by: Sachin Pisal <[email protected]>
Signed-off-by: Sachin Pisal <[email protected]>
Signed-off-by: Sachin Pisal <[email protected]>
sacpis
force-pushed
the
check_vector_size_for_the_power_of_2
branch
from
4257988 to
a1dda5a
Compare
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2490
Before
After
Test result