New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JAX fix a (rare) bug related to vmap of tensor_product #73

Merged

mariogeiger merged 1 commit into main from fix-jax-primitive-shape-bug

Jan 23, 2025

+62 −39

Collaborator

mariogeiger commented Jan 22, 2025

in some rare cases of repeated inputs like this:

def h(x):
    d = cue.descriptors.spherical_harmonics(cue.SO3(1), [2]).d
    return cuex.tensor_product(d, x, x)

jax.jacobian(h)(jnp.array([1.0, 0.0, 0.0]))

For the operand 0, the input and output have different leading shapes.

This was unfortunately not allowed, this PR changes this


          tensor_product_p: shapes -> output_shapes

68d67a3

mariogeiger requested a review from sureshramani23

January 22, 2025 16:00

mariogeiger merged commit bcc2847 into main

11 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet