Fix shared weights for IWeightedSymmetricTPDispatcher #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariogeiger
commented
Jan 13, 2025
| @@ -127,9 +148,16 @@ def test_precision_cuda_vs_fx( | |||
| if not torch.cuda.is_available(): | |||
| pytest.skip("CUDA is not available") | |||
|
|
|||
| if shared_op0 and batch_size == 0: | |||
| pytest.skip("shared_op0 requires batch_size > 0") # TODO: fix this | |||
There was a problem hiding this comment.
@v0i0 uniform1d is not behaving properly when the first operand has batch 1 but the other ones have batch 0.
We would expect the output to be of batch size 0 if at least one input if of batch size 0.
borisfom
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.