-
Notifications
You must be signed in to change notification settings - Fork 302
Add missing nvrtc nv target archs #6880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hm, this is probably not safe, because if nvrtc expects the nv target macros in another builtin headers, the compilation will fail |
This comment has been minimized.
This comment has been minimized.
|
I guess for tests, this is fine. Please also add a comment to each explaining how this disables nvrtc's builtin header. |
7c0cbde to
80a9139
Compare
<nv/target>|
With @wmaxey we are working on #6881, so we needn't to deal with this problem ever again. I changed this PR to just add the missing architectures. Hopefully we do this for the very last time. @alliepiper this should fix our libcu++ nightlies. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
bernhardmgruber
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hate that we have to do this. LGTM.
This fix is on the way, but I believe we will have to keep doing this till CUDA 15 :D |
🥳 CI Workflow Results🟩 Finished in 4h 01m: Pass: 100%/91 | Total: 2d 12h | Max: 3h 00m | Hits: 80%/198656See results here. |
(cherry picked from commit fb9b3e5)
|
Successfully created backport PR for |
Edit 2: Just adding missing nv target macros for archs 103, 110 and 120.