[Common] Pack attention arguments as structs#3079
Draft
cyanguwa wants to merge 2 commits into
Draft
Conversation
Signed-off-by: Charlene Yang <8636796+cyanguwa@users.noreply.github.com>
for more information, see https://pre-commit.ci
timmoon10
reviewed
Jun 3, 2026
Member
There was a problem hiding this comment.
Instead of exposing all of the options in a struct, it may be worth considering putting them in an opaque object like NVTEQuantizationConfig:
This has a few advantages:
- The struct definition is fully within the core lib, so it's more robust to cases where
libtransformer_engine.soandtransformer_engine_torchare from different TE versions. - Default initialization is automatic and doesn't require the non-standard init macros.
- It's easier to deprecate options. Remove the option from the internal struct, and either error out or ignore if the user attempts to set it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a brief summary of the changes, relevant motivation and context.
Fixes # (issue)
Type of change
Changes
Please list the changes introduced in this PR:
Checklist: