ci: add premerge check for tilegym- skill naming convention#148
Closed
hannahli-nv wants to merge 2 commits into
Closed
ci: add premerge check for tilegym- skill naming convention#148hannahli-nv wants to merge 2 commits into
hannahli-nv wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/scripts/check_skill_naming.py— a lightweight Python script that detects any newskills/<name>/directory added in a PR and verifies that:tilegym-name:field inskills/<name>/SKILL.mdstarts withtilegym-.github/workflows/check-skill-naming.yml— a GitHub Actions workflow that runs the above script on every PR touchingskills/**. The workflow only fires whenskills/changes, so it adds no overhead to unrelated PRs.Motivation
Skills published to the
nvidia/skillsregistry must use project-scoped prefixes to avoid name collisions. Existing TileGym skills were already renamed totilegym-*. This check enforces the convention for all future contributions — failing at premerge with a clear message and fix instructions rather than discovering the issue post-merge.The check is additive: it only inspects newly added skill directories, so it never blocks PRs that modify existing skills.
Error output when a violation is found
Test plan
skills/directorytilegym-prefixskills/CI Configuration
🤖 Generated with Claude Code