Skip to content

Conversation

@IzzyPutterman
Copy link
Contributor

@IzzyPutterman IzzyPutterman commented Nov 12, 2025

What does this PR do?

SGLang Fix for actually passing the draft model path to the engine

vLLM Fix for multiturn to not overlap request_id strings

Acceptance Rate Fix for potential race condition on multiturn datasets in writing back AR

Overview: ?

Usage

# Add a code snippet demonstrating how to use this

Testing

Before your PR is "Ready for review"

  • Make sure you read and follow Contributor guidelines and your commits are signed.
  • Is this change backward compatible?: Yes/No
  • Did you write any new necessary tests?: Yes/No
  • Did you add or update any necessary documentation?: Yes/No
  • Did you update Changelog?: Yes/No

Additional Information

@IzzyPutterman IzzyPutterman requested a review from a team as a code owner November 12, 2025 06:21
@codecov
Copy link

codecov bot commented Nov 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.37%. Comparing base (7d0f7a9) to head (1f7e8cb).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #541   +/-   ##
=======================================
  Coverage   74.37%   74.37%           
=======================================
  Files         182      182           
  Lines       18219    18219           
=======================================
  Hits        13550    13550           
  Misses       4669     4669           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yeyu-nvidia
Copy link
Contributor

Can you add some description of this PR?

@IzzyPutterman
Copy link
Contributor Author

Can you add some description of this PR?

Updated the description

Copy link
Contributor

@h-guo18 h-guo18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants