feat(gemma): qualify gemma-3-270m and refuse fp16 for Gemma 3 - #1327
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 12 included reviews per hour; 10 remain after this review. 📝 SummarySummaryAdds
Architecture impact
Review statusHUMAN REVIEW REQUIRED No evidence-backed blocking violation is supplied. Review finding counts are unavailable. Human review is required for the unresolved official-checkpoint compatibility question. WalkthroughThe change adds a Gemma 3 270M test manifest, excludes it from release-performance profiles, and rejects fp16 builds for Gemma 3 model types while preserving Gemma 2 fp16 gate behavior. ChangesGemma 3 support
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Feature Merge Risk: ⚪ Minimal · up to The Gemma 3 qualification and fp16 safety guard introduce no evidenced merge-blocking risk. 🚥 Pre-merge checks | ✅ 8 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (8 passed)
Full details: Description checkExplanation The description uses the required sections and records substantial validation evidence, but it is materially stale. It still states that gemma-3-12b is included and passed validation, while the current objectives state that its manifest was removed after an NED 0.8387 failure. Resolution Update the description to cover only gemma-3-270m and the FP16 refusal. Remove the gemma-3-12b implementation and validation claims, update the exit criteria and affected models, and record the failed gemma-3-12b premerge result and reason for exclusion under Not Run / Remaining Gaps or Notes For Future Readers. Comment |
Signed-off-by: Zhenshan Xie <zhenshanx@nvidia.com>
5d5680c to
b28d154
Compare
|
Dropped The internal premerge run on The HF reference produced
|
Background
#1304 added the Gemma 3 text path and qualified the 1B and 4B. Google publishes three more
text-capable widths; this qualifies two of them on that same path, with no code change to the
builder, and closes off a precision that is not safe for the generation.
gemma-3-270mis 268M — the smallest useful model this repository builds.gemma-3-12bisstructurally identical to the already-qualified 4B: same
Gemma3ForConditionalGeneration,nested
text_config,sliding_window1024, pattern 6,rope_local_base_freq10000,rope_theta1e6, linear rope scaling factor 8,query_pre_attn_scalar256 — only wider(48 layers, hidden 3840, 16 heads, 8 KV heads).
Exit Criteria
Implementation
Manifests only for the two widths. The one code change is the fp16 refusal.
Change categories
Validation
Commands and Results
Both built at bf16 and driven through the native CLI against the Hugging Face reference,
using the prompt rendering and metric of
families/gemma/tests/test_e2e.py:[50429, 107, 106]Paris[50429, 106]ParisWhy fp16 is refused. Largest absolute value leaving a decoder layer, reference in fp32,
against the fp16 maximum of 65,504:
The 1B fits on one prompt by 7%, which is luck rather than headroom, so the refusal covers the
generation rather than individual widths. Gemma 2 keeps fp16 on its measured margin.
Other suites:
families/gemma/tests/— 35 passed, 2 of them newapps/benchmark/trtmc_benchmark/tests— 1107 passedruff checkcleanHardware, Environment, and Revisions
google/gemma-3-270m-itandgoogle/gemma-3-12b-it. Those reposare gated and this container has no HF token, so local verification used the
unslothmirrors of the same weights; CI fetches the official ones, as it already does for
gemma-2-2b-itand the widths in feat(gemma): add Gemma 3 text support (1B, 4B) and fix the Gemma stop tokens #1304.29facea2Not Run / Remaining Gaps
gemma-3-27bis deliberately not in this PR. It is the last text width and needs alarge-memory host to build — the comparable Qwen3.6-27B build peaked at 291 GB — so it is
being qualified separately rather than shipped unverified here.
excluded_profiles, not benchmarked: the release-performance receipt wascollected only for
gemma-2-2b, which exercises the same builder and runtime path.Contributor Self-Review
Notes For Future Readers
The fp16 numbers are the part worth keeping. Gemma 3 was qualified at bf16 in #1304 after fp16
produced a single repeated token, but the reason was not established at the time. Measuring the
activations settles it: this is range, not a graph defect, and the 1B "working" at fp16 is an
accident of one prompt landing 7% inside the limit. Refusing per width would have shipped that
accident as a supported configuration.
Third-party provenance: Gemma is published by Google; the checkpoints are the
google/gemma-3-270m-itandgoogle/gemma-3-12b-itHugging Face repositories.Risk level
Two manifests on an existing code path, plus a refusal that only narrows what can be built.
No checkpoint that builds correctly today is affected.