test(qwen): probe chunked-prefill validation gap - #1324
chaofengw-nv wants to merge 3 commits into
Conversation
Deliberately replay the second prefill chunk after the first two chunks. This mutation should corrupt long-prompt semantics while preserving the runtime receipt metrics checked by the existing long-context case. This commit exists only to test whether premerge catches the false green and must not be merged. Signed-off-by: chaofengw <chaofengw@nvidia.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueComment |
Probe resultConfirmed false green. Do not merge this PR.
This demonstrates that the current premerge coverage can accept a Qwen chunked-prefill semantic regression. The PR remains Draft and must be closed, not merged, after the evidence is captured. |
Make contract-only validation explicit and place the native-KV parity question in the third prefill chunk so stale or replayed input pointers fail the HF comparison. Signed-off-by: chaofengw <chaofengw@nvidia.com>
Signed-off-by: chaofengw <chaofengw@nvidia.com>
|
This is an automated Internal CI result; no review from an individual maintainer is requested. Open the public Source Actions run from the automated status link above. |
Final negative-control resultThe experiment is complete. Do not merge this PR.
This PR contains deliberate runtime corruption and is being closed as preserved negative-control evidence, without merge. |
Background
This Draft PR is an intentional mutation experiment. The Qwen long-context E2E case validates prefill receipts across 513 chunks, while semantic parity is covered only by a shorter case. This PR tests whether premerge can reject a semantic corruption that begins after the second prefill chunk.
Exit Criteria
TRTMC Internal CI / Automated premerge gateresult.Implementation
Change categories
Validation
Commands and Results
clang-format --dry-run --Werror families/qwen/runtime/pipeline.cpp: passed.pytest families/qwen/tests/test_e2e.py -q: 3 passed, 12 skipped; GPU E2E is intentionally left to exact-head premerge CI.Hardware, Environment, and Revisions
aa75b06e022d1fbe00f209affd4207c0911af72e.clang-format.Not Run / Remaining Gaps
Contributor Self-Review
Notes For Future Readers
QwenTextGenerationPipeline::run_prefill_batched.Risk level
High risk by design: the mutation silently substitutes stale prompt tokens after the second prefill chunk. The Draft state and explicit do-not-merge exit criterion are required safeguards.