[Tripy] Add __len__ for tp.Shape and infer length statically when possible
#92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can confirm that the CI passes. |
slyubomirsky
force-pushed
the
tripy-infer-shape-len
branch
2 times, most recently
from
60d624a to
bb41ae4
Compare
parthchadha
reviewed
Aug 14, 2024
slyubomirsky
force-pushed
the
tripy-infer-shape-len
branch
from
bb41ae4 to
325ff59
Compare
|
@slyubomirsky can you rebase your branch? This will help run CI on github. |
slyubomirsky
force-pushed
the
tripy-infer-shape-len
branch
from
325ff59 to
f65a6ea
Compare
parthchadha
approved these changes
Aug 19, 2024
slyubomirsky
force-pushed
the
tripy-infer-shape-len
branch
from
f65a6ea to
3683872
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some cases, it is useful to know the length of a
tp.Shapewithout executing the model. This PR adds a methodinfer_lenthat allows operators to specify how to statically infer the length ofShapeoutputs when possible (it is always optional). Test cases are added.