Refactors trace operations to be more self-contained, separates front… #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…end/trace tensors more cleanly
- Refactors Trace operation so that it reports how many outputs it generates instead
of requiring the caller to know.
The trace op is now also responsible for creating its own output trace
tensors. Additionally, `build`/`build_internal` have been removed, meaning
the trace does *not* create frontend tensors anymore.
Frontend tensors no longer create trace tensors directly but instead only
interface with ops and wrap their outputs as needed.
- Consolidates and renames some frontend Tensor constructors to better reflect
their purpose. For example, `create_directly` -> `fast_init`.
- Temporarily removes the "how to add ops" guide. A new version of this will be
written once we have switched to the TRT dialect, which will signficantly affect
how ops are added.
pranavm-nvidia
force-pushed
the
trace-ops-refactor
branch
from
2c8c169 to
09d75a6
Compare
yizhuoz004
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…end/trace tensors more cleanly
Refactors Trace operation so that it reports how many outputs it generates instead of requiring the caller to know.
The trace op is now also responsible for creating its own output trace
tensors. Additionally,
build/build_internalhave been removed, meaningthe trace does not create frontend tensors anymore.
Frontend tensors no longer create trace tensors directly but instead only
interface with ops and wrap their outputs as needed.
Consolidates and renames some frontend Tensor constructors to better reflect their purpose. For example,
create_directly->fast_init.Temporarily removes the "how to add ops" guide. A new version of this will be written once we have switched to the TRT dialect, which will signficantly affect how ops are added.