Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to compile against shared OpenAL lib #390

Merged
merged 1 commit into from
Apr 1, 2024
Merged

Add option to compile against shared OpenAL lib #390

merged 1 commit into from
Apr 1, 2024

Conversation

runlevel5
Copy link
Contributor

@runlevel5 runlevel5 commented Mar 27, 2024 •
edited
Loading

Issue

#306

Motivation

Having the flexibility to opt in shared system lib is a big plus for packaging

Changes

  • Add USE_SYSTEM_OPENAL option

res2k
res2k reviewed Mar 27, 2024
View reviewed changes
src/CMakeLists.txt Outdated Show resolved Hide resolved
@runlevel5 runlevel5 marked this pull request as draft March 27, 2024 10:31
@runlevel5 runlevel5 marked this pull request as ready for review March 27, 2024 10:37
@apanteleev apanteleev merged commit 945023c into NVIDIA:master Apr 1, 2024
2 checks passed
@runlevel5 runlevel5 deleted the openal-shared branch April 2, 2024 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@res2k res2k res2k left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@runlevel5 @FireBurn @res2k @apanteleev