Add option to compile against shared Zlib #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runlevel5
commented
Mar 27, 2024
| @@ -43,7 +45,7 @@ if (IS_64_BIT) | |||
| option(SDL_TEST OFF) | |||
|
|
|||
| if (CONFIG_LINUX_STEAM_RUNTIME_SUPPORT) | |||
| option(INPUT_TSLIB OFF) | |||
| option(INPUT_TSLIB OFF) | |||
There was a problem hiding this comment.
Replace tab with 4 spaces
|
FYI @Connor-GH |
res2k
reviewed
Mar 27, 2024
|
@res2k I've amended the PR based on your feedback |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#306
Motivation
The Zlib lib has caused lots of pain for many Linux distro which have custom patches. By offering an option to use the system zlib, it would greatly simplify the adoption and maintenance of distro packaging
Changes
USE_SYSTEM_ZLIBflag