Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix gcc warning that fov_scale may be used uninitialized #364

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Fix gcc warning that fov_scale may be used uninitialized #364

merged 1 commit into from
Dec 7, 2023

Conversation

res2k
Copy link
Contributor

@res2k res2k commented Nov 23, 2023

...which is actually true for PROJECTION_CYLINDRICAL.

@res2k res2k changed the title Fix gcc warning that fov_scale may be used unitialized Fix gcc warning that fov_scale may be used uninitialized Nov 23, 2023
@RandomDude4
Copy link
Contributor

RandomDude4 commented Dec 1, 2023 •
edited
Loading

Sorry, that's my fault.
The same should be true for "float rad_per_pixel" which is defined just above fov_scale (as it is not used in most of the switch cases), but for some reason I do not get the same warning for it.

@apanteleev apanteleev merged commit c2fafb4 into NVIDIA:master Dec 7, 2023
2 checks passed
@res2k res2k deleted the fix-gcc-warning branch January 21, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@res2k @RandomDude4 @apanteleev