Skip to content

fix: prevent command injection in isRepoPrivate() #973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Aakeeo wants to merge 2 commits into
base: main
Choose a base branch
from
+9 −3
Open

fix: prevent command injection in isRepoPrivate() #973

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b52213
fix: prevent command injection in isRepoPrivate()
Aakeeo Mar 26, 2026
0f0f8b1
fix: use execFileSync for gh auth token call for consistency
Aakeeo Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions bin/lib/credentials.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
const fs = require("fs");
const path = require("path");
const readline = require("readline");
const { execSync } = require("child_process");
const { execFileSync } = require("child_process");

const CREDS_DIR = path.join(process.env.HOME || "/tmp", ".nemoclaw");
const CREDS_FILE = path.join(CREDS_DIR, "credentials.json");
Expand Down Expand Up @@ -174,7 +174,10 @@ async function ensureApiKey() {

function isRepoPrivate(repo) {
try {
const json = execSync(`gh api repos/${repo} --jq .private 2>/dev/null`, { encoding: "utf-8" }).trim();
const json = execFileSync("gh", ["api", `repos/${repo}`, "--jq", ".private"], {
encoding: "utf-8",
stdio: ["ignore", "pipe", "ignore"],
}).trim();
return json === "true";
} catch {
return false;
Expand All @@ -189,7 +192,10 @@ async function ensureGithubToken() {
}

try {
token = execSync("gh auth token 2>/dev/null", { encoding: "utf-8" }).trim();
token = execFileSync("gh", ["auth", "token"], {
encoding: "utf-8",
stdio: ["ignore", "pipe", "ignore"],
}).trim();
if (token) {
process.env.GITHUB_TOKEN = token;
return;
Expand Down