Skip to content

fix(cli): show live gateway model/provider in list and status commands#1041

Open
Junior00619 wants to merge 1 commit intoNVIDIA:mainfrom
Junior00619:fix/list-status-live-inference
Open

fix(cli): show live gateway model/provider in list and status commands#1041
Junior00619 wants to merge 1 commit intoNVIDIA:mainfrom
Junior00619:fix/list-status-live-inference

Conversation

@Junior00619
Copy link
Copy Markdown
Contributor

@Junior00619 Junior00619 commented Mar 28, 2026

Problem

nemoclaw list and nemoclaw status show model: unknown and provider: unknown even when the gateway has a configured inference route (#986).

Both commands only read model/provider from the local registry (~/.nemoclaw/sandboxes.json). The registry stores null for these fields when inference is configured after initial onboarding (e.g. via openshell inference set), or when the user changes providers post-onboard.

The per-sandbox nemoclaw <name> status command already handles this correctly by querying the live gateway.

Fix

Query openshell inference get once per invocation in both listSandboxes() and showStatus(), and prefer the live gateway values over stale registry entries — matching the existing sandboxStatus() pattern.

Falls back gracefully to registry values (or "unknown") when the gateway is unreachable.

Changes

  • bin/nemoclaw.js: listSandboxes() and showStatus() now call captureOpenshell(["inference", "get"]) and prefer live model/provider
  • test/cli.test.js: Two new tests:
    • Live inference overrides null registry values (no "unknown" in output)
    • Graceful fallback to registry values when openshell fails

Testing

  • 602 tests pass (2 pre-existing failures in install-preflight.test.js on main)
  • ESLint clean, all pre-commit hooks pass

Fixes #986

Summary by CodeRabbit

  • New Features

    • The sandbox listing now displays live model and provider information sourced from the gateway when available.
  • Bug Fixes

    • Improved fallback handling to use stored registry values when live gateway data is unavailable.
  • Tests

    • Added test coverage for live inference data retrieval and fallback scenarios.

nemoclaw list and the global status display only read model/provider from the
local registry, which stores null when inference is configured after onboarding
(e.g. via openshell inference set). This makes both commands show 'unknown'
even when the gateway has a configured inference route.

Query openshell inference get once per invocation and prefer the live values
over stale registry entries, matching the existing behavior of the per-sandbox
status command.

Fixes NVIDIA#986
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 28, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: ba065850-4f06-435b-bcb4-5d1bd30ab3a8

📥 Commits

Reviewing files that changed from the base of the PR and between eb4ba8c and fa91791.

📒 Files selected for processing (2)
  • bin/nemoclaw.js
  • test/cli.test.js

📝 Walkthrough

Walkthrough

The changes modify the nemoclaw list and nemoclaw status commands to query live gateway inference configuration and display the actual model and provider instead of only showing registry-stored values, with fallback to existing data when queries fail.

Changes

Cohort / File(s) Summary
Gateway Inference Integration
bin/nemoclaw.js
Modified showStatus() and listSandboxes() to query live gateway inference via openshell inference get, parse results with parseGatewayInference, and prefer live model/provider values over registry values with graceful fallback to existing data.
Test Coverage
test/cli.test.js
Added new test suite for list command validating successful inference model/provider display and fallback behavior when gateway query fails.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰 ears wiggle with joy
Unknown became known with a gateway query keen,
Live inference revealed what was previously unseen!
From list to status, the models now brightly shine,
With graceful fallback—a regression fixed, hop huzzah! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title accurately describes the main change: updating list and status commands to display live gateway model/provider instead of unknown values.
Linked Issues check ✅ Passed The changes directly address issue #986 by modifying listSandboxes() and showStatus() to query live gateway inference and prefer those values over stale registry entries, with graceful fallback.
Out of Scope Changes check ✅ Passed All changes are scoped to fixing the reported issue: modifications to bin/nemoclaw.js for live inference querying and corresponding test coverage in test/cli.test.js.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[NemoClaw][Unbuntu][Regression] nemoclaw list/status shows sandbox model and provider as unknown even when gateway inference is configured

1 participant