fix(cli): show live gateway model/provider in list and status commands#1041
fix(cli): show live gateway model/provider in list and status commands#1041Junior00619 wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
nemoclaw list and the global status display only read model/provider from the local registry, which stores null when inference is configured after onboarding (e.g. via openshell inference set). This makes both commands show 'unknown' even when the gateway has a configured inference route. Query openshell inference get once per invocation and prefer the live values over stale registry entries, matching the existing behavior of the per-sandbox status command. Fixes NVIDIA#986
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe changes modify the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Problem
nemoclaw listandnemoclaw statusshowmodel: unknownandprovider: unknowneven when the gateway has a configured inference route (#986).Both commands only read model/provider from the local registry (
~/.nemoclaw/sandboxes.json). The registry storesnullfor these fields when inference is configured after initial onboarding (e.g. viaopenshell inference set), or when the user changes providers post-onboard.The per-sandbox
nemoclaw <name> statuscommand already handles this correctly by querying the live gateway.Fix
Query
openshell inference getonce per invocation in bothlistSandboxes()andshowStatus(), and prefer the live gateway values over stale registry entries — matching the existingsandboxStatus()pattern.Falls back gracefully to registry values (or
"unknown") when the gateway is unreachable.Changes
bin/nemoclaw.js:listSandboxes()andshowStatus()now callcaptureOpenshell(["inference", "get"])and prefer live model/providertest/cli.test.js: Two new tests:"unknown"in output)Testing
install-preflight.test.jsonmain)Fixes #986
Summary by CodeRabbit
New Features
Bug Fixes
Tests