Skip to content

fix(scripts): add signal handlers to nemoclaw-start.sh for graceful container shutdown #1024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
latenighthackathon wants to merge 2 commits into
base: main
Choose a base branch
from
+27 −1
Open

fix(scripts): add signal handlers to nemoclaw-start.sh for graceful container shutdown #1024

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
85b8f4e
fix(scripts): add signal handlers to nemoclaw-start.sh for graceful c…
latenighthackathon Mar 27, 2026
99624fe
fix(scripts): wait for auto-pair and exit from cleanup to avoid doubl…
latenighthackathon Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion scripts/nemoclaw-start.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,8 @@ while time.time() < DEADLINE:
else:
print(f'[auto-pair] watcher timed out approvals={APPROVED}')
PYAUTOPAIR
echo "[gateway] auto-pair watcher launched (pid $!)"
AUTO_PAIR_PID=$!
echo "[gateway] auto-pair watcher launched (pid $AUTO_PAIR_PID)"
}

# ── Main ─────────────────────────────────────────────────────────
Expand Down Expand Up @@ -242,6 +243,17 @@ if [ "$(id -u)" -ne 0 ]; then
echo "[gateway] openclaw gateway launched (pid $GATEWAY_PID)"
start_auto_pair
print_dashboard_urls

# Forward SIGTERM/SIGINT to child processes for graceful shutdown.
# This script is PID 1 — without a trap, signals interrupt wait and
# children are orphaned until Docker sends SIGKILL after the grace period.
cleanup() {
echo "[gateway] received signal, forwarding to children..."
kill -TERM "$GATEWAY_PID" "${AUTO_PAIR_PID:-}" 2>/dev/null
wait "$GATEWAY_PID" 2>/dev/null
}
trap cleanup SIGTERM SIGINT

wait "$GATEWAY_PID"
exit $?
fi
Expand Down Expand Up @@ -293,6 +305,16 @@ echo "[gateway] openclaw gateway launched as 'gateway' user (pid $GATEWAY_PID)"
start_auto_pair
print_dashboard_urls

# Forward SIGTERM/SIGINT to child processes for graceful shutdown.
# This script is PID 1 — without a trap, signals interrupt wait and
# children are orphaned until Docker sends SIGKILL after the grace period.
cleanup() {
echo "[gateway] received signal, forwarding to children..."
kill -TERM "$GATEWAY_PID" "${AUTO_PAIR_PID:-}" 2>/dev/null
wait "$GATEWAY_PID" 2>/dev/null
}
trap cleanup SIGTERM SIGINT

# Keep container running by waiting on the gateway process.
# This script is PID 1 (ENTRYPOINT); if it exits, Docker kills all children.
wait "$GATEWAY_PID"