fix(policy): use access: full for gateway.discord.gg in default sandbox policy#1004
fix(policy): use access: full for gateway.discord.gg in default sandbox policy#1004deepujain wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
…ox policy The discord entry in openclaw-sandbox.yaml used protocol: rest for gateway.discord.gg, which causes the OpenShell proxy to apply L7 HTTP inspection to WebSocket connections. Discord detects the TLS intercept and never sends the HELLO packet, causing 30s connection timeouts. The presets/discord.yaml already carried the correct fix (access: full, CONNECT tunnel) with an explanatory comment referencing NVIDIA#409, but the default sandbox policy was not updated to match. Align openclaw-sandbox.yaml with the preset: replace the protocol: rest block for gateway.discord.gg with access: full and add the same explanatory comment so the intent is clear. Fixes NVIDIA#979 Signed-off-by: Deepak Jain <[email protected]>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughA network policy endpoint for Discord's gateway in the sandbox configuration was modified to change from HTTP REST with TLS termination and explicit method rules to a tunnel-style full access model, affecting only the specified endpoint configuration. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Summary
The default sandbox policy in
openclaw-sandbox.yamlstill usesprotocol: restforgateway.discord.gg, which causes the OpenShell proxy to apply L7 HTTP inspection to WebSocket connections. Discord detects the TLS intercept and never sends the HELLO packet, causing 30-second connection timeouts (#979).The fix already existed in
presets/discord.yaml(added to address #409), but the same change was never applied to the base sandbox policy. This PR closes the gap.Changes
nemoclaw-blueprint/policies/openclaw-sandbox.yaml— replaceprotocol: restblock forgateway.discord.ggwithaccess: full(CONNECT tunnel) and add the explanatory comment from the preset so the intent is clear to future readersWhy
access: fullmatters hereprotocol: resttells the proxy to terminate TLS and inspect HTTP. For a WebSocket upgrade this activates Layer-7 inspection, which Discord recognises as a MITM and refuses to HELLO.access: fullissues a raw CONNECT tunnel, bypassing HTTP-level inspection entirely -- the same approach thatcurluses and that already works.Testing
npm testpasses (542/542). Policy-only change; no build step needed.Fixes #979
Signed-off-by: Deepak Jain [email protected]
Summary by CodeRabbit