Skip to content

fix(cli): parse codex plugin list text output instead of --json #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rapids-bot merged 3 commits into from
Jun 27, 2026
Merged

fix(cli): parse codex plugin list text output instead of --json #314

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1ceaaa2
fix(cli): parse codex `plugin list` text output instead of --json
zhongxuanwang-nv Jun 25, 2026
be06cea
test(cli): relocate claude plugin-list parse-error coverage
zhongxuanwang-nv Jun 25, 2026
df5e275
refactor(cli): trim non-essential comments in codex plugin-list fix
zhongxuanwang-nv Jun 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 21 additions & 11 deletions crates/cli/src/plugin_install/host.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,17 +220,27 @@ fn codex_plugin_registered(
options: &PluginInstallOptions,
runner: &dyn CommandRunner,
) -> Result<bool, String> {
let output = run_capture_command(
"codex",
&["plugin".into(), "list".into(), "--json".into()],
options,
runner,
)?;
let plugins = parse_json_command_output("codex plugin list --json", output)?;
Ok(plugins
.get("installed")
.and_then(Value::as_array)
.is_some_and(|plugins| plugins.iter().any(plugin_entry_matches)))
// Codex `plugin list` has no `--json` flag, so parse its text table the same way
// `codex_marketplace_registered` parses `plugin marketplace list`.
let output = run_capture_command("codex", &["plugin".into(), "list".into()], options, runner)?;
let plugin_id = format!("{PLUGIN_NAME}@{MARKETPLACE_NAME}");
Ok(output
.stdout
.lines()
.any(|line| codex_plugin_line_installed(line, &plugin_id)))
}

// Codex `plugin list` rows are `<id> <status> <version> <path>`. An installed
// plugin's status starts with `installed` (e.g. `installed, enabled`), while an
// available-but-uninstalled one is `not installed`.
fn codex_plugin_line_installed(line: &str, plugin_id: &str) -> bool {
let mut columns = line.split_whitespace();
if columns.next() != Some(plugin_id) {
return false;
}
columns
.next()
.is_some_and(|status| status.starts_with("installed"))
}

fn codex_marketplace_registered(
Expand Down
75 changes: 39 additions & 36 deletions crates/cli/tests/coverage/plugin_install_tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -559,21 +559,17 @@ fn host_command_helpers_cover_dry_run_missing_failure_and_reporting() {
);

let runner = MockRunner::default()
.with_executable("codex", "/bin/codex")
.with_capture_output("/bin/codex plugin list --json", "not json")
.with_capture_output("/bin/codex plugin marketplace list", "");
.with_executable("claude", "/bin/claude")
.with_capture_output("/bin/claude plugin list --json", "not json");
assert!(
host_registration_report(PluginHost::Codex, &normal, &runner)
host_registration_report(PluginHost::ClaudeCode, &normal, &runner)
Comment thread
zhongxuanwang-nv marked this conversation as resolved.
Outdated
.unwrap_err()
.contains("failed to parse")
);

let runner = MockRunner::default()
.with_executable("codex", "/bin/codex")
.with_capture_output(
"/bin/codex plugin list --json",
json!({"installed": []}).to_string(),
)
.with_capture_output("/bin/codex plugin list", "PLUGIN STATUS VERSION PATH\n")
.with_capture_output("/bin/codex plugin marketplace list", "MARKETPLACE ROOT\n");
let error = validate_host_registration(PluginHost::Codex, &normal, &runner).unwrap_err();
assert!(
Expand Down Expand Up @@ -618,30 +614,41 @@ fn host_registration_report_accepts_claude_and_codex_shape_variants() {
assert!(report.host_marketplace_registered);
}

for plugin_entry in [
json!({"id": plugin_id.clone()}),
json!({"pluginId": plugin_id.clone()}),
json!({"name": PLUGIN_NAME, "marketplaceName": MARKETPLACE_NAME}),
] {
let runner = MockRunner::default()
.with_executable("codex", "/bin/codex")
.with_capture_output(
"/bin/codex plugin list --json",
json!({"installed": [plugin_entry]}).to_string(),
)
.with_capture_output(
"/bin/codex plugin marketplace list",
format!("{MARKETPLACE_NAME} /tmp/nemo-relay-local\n"),
);
let report = host_registration_report(PluginHost::Codex, &normal, &runner).unwrap();
assert!(report.ok());
}
// Codex `plugin list` is a text table; an installed row registers the plugin.
let runner = MockRunner::default()
.with_executable("codex", "/bin/codex")
.with_capture_output(
"/bin/codex plugin list",
format!("{plugin_id} installed, enabled 0.4.0 /tmp/nemo-relay-plugin\n"),
)
.with_capture_output(
"/bin/codex plugin marketplace list",
format!("{MARKETPLACE_NAME} /tmp/nemo-relay-local\n"),
);
let report = host_registration_report(PluginHost::Codex, &normal, &runner).unwrap();
assert!(report.ok());

// A row that is present but `not installed` must not count as registered.
let runner = MockRunner::default()
.with_executable("codex", "/bin/codex")
.with_capture_output(
"/bin/codex plugin list",
format!("{plugin_id} not installed\n"),
)
.with_capture_output(
"/bin/codex plugin marketplace list",
format!("{MARKETPLACE_NAME} /tmp/nemo-relay-local\n"),
);
let report = host_registration_report(PluginHost::Codex, &normal, &runner).unwrap();
assert!(!report.host_plugin_registered);
assert!(report.host_marketplace_registered);

// A plugin installed under a different marketplace id must not match.
let runner = MockRunner::default()
.with_executable("codex", "/bin/codex")
.with_capture_output(
"/bin/codex plugin list --json",
json!({"installed": [{"name": PLUGIN_NAME, "marketplaceName": "other"}]}).to_string(),
"/bin/codex plugin list",
format!("{PLUGIN_NAME}@other installed, enabled 0.4.0 /tmp/other\n"),
)
.with_capture_output("/bin/codex plugin marketplace list", "other /tmp/other\n");
let report = host_registration_report(PluginHost::Codex, &normal, &runner).unwrap();
Expand Down Expand Up @@ -1328,13 +1335,9 @@ fn doctor_json_uses_quiet_plugin_report() {
.with_executable("nemo-relay", "/bin/nemo-relay")
.with_executable("codex", "/bin/codex")
.with_capture_output(
"/bin/codex plugin list --json",
json!({
"installed": [
{ "pluginId": "nemo-relay-plugin@nemo-relay-local" }
]
})
.to_string(),
"/bin/codex plugin list",
"PLUGIN STATUS VERSION PATH\n\
nemo-relay-plugin@nemo-relay-local installed, enabled 0.4.0 /tmp/nemo-relay-plugin\n",
)
.with_capture_output(
"/bin/codex plugin marketplace list",
Expand All @@ -1357,7 +1360,7 @@ fn doctor_json_uses_quiet_plugin_report() {
assert_eq!(
runner.capture_commands(),
vec![
"/bin/codex plugin list --json",
"/bin/codex plugin list",
"/bin/codex plugin marketplace list"
]
);
Expand Down
Loading