Skip to content

fix: pass a real ScopeHandle to Node withScope callbacks #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhongxuanwang-nv merged 3 commits into from
Jun 2, 2026
+99 −25
Merged

fix: pass a real ScopeHandle to Node withScope callbacks #196

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9022420
docs: fix Node.js quickstart scope handle and LLM request usage
zhongxuanwang-nv May 31, 2026
69cbb21
fix: pass a real ScopeHandle to Node withScope callbacks
zhongxuanwang-nv Jun 2, 2026
9a43f1a
docs: keep Node quick start using LlmRequest
zhongxuanwang-nv Jun 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion crates/node/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,8 @@ async function main() {
});

await withScope("demo-agent", ScopeType.Agent, async (handle) => {
event("initialized", handle, { binding: "node" }, null);
// `handle` describes the active scope; pass null to target the current scope.
Comment thread
zhongxuanwang-nv marked this conversation as resolved.
Outdated
event("initialized", null, { binding: "node" }, null);
});

deregisterSubscriber("printer");
Expand Down
11 changes: 6 additions & 5 deletions docs/getting-started/quick-start/nodejs.mdx
View file
Open in desktop
Comment thread
zhongxuanwang-nv marked this conversation as resolved.
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ const {
registerSubscriber,
deregisterSubscriber,
flushSubscribers,
LlmRequest,
withScope,
event,
toolCallExecute,
Expand All @@ -57,23 +56,25 @@ async function main() {
});

await withScope("demo-agent", ScopeType.Agent, async (handle) => {
event("initialized", handle, { binding: "node" }, null);
// `handle` describes the active scope (handle.uuid, handle.name, handle.scopeType).
// For lifecycle calls inside the scope, pass null to target the current scope.
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Outdated
event("initialized", null, { binding: "node" }, null);

const toolResult = await toolCallExecute(
"search",
{ query: "hello" },
(args) => ({ echo: args.query }),
handle,
null,
null,
null,
null,
);

const llmResult = await llmCallExecute(
"demo-provider",
new LlmRequest({}, { messages: [{ role: "user", content: "hi" }] }),
{ headers: {}, content: { messages: [{ role: "user", content: "hi" }] } },
(request) => ({ ok: true, messages: request.content.messages }),
handle,
null,
null,
null,
null,
Expand Down