Skip to content

Conversation

edlee123
Copy link

Overview

This PR makes Docker deployment improvements and closes Issue #23.

Key Changes

Added compose_calculator.yaml for a one-command deployment of the calculator example with:

  • Pre-configured environment variables for seamless UI + calculator server connectivity
  • A bridge network for secure container-to-container communication
  • Added health checks to ensure proper service startup sequence
  • Phoenix telemetry setup on port 6006 for monitoring and debugging

Updated README.md to:

  • Add Docker Compose instructions for the simple calculator example.
  • Provided instructions for starting, checking status, and stopping the services
  • Maintained existing manual calculator setup instructions for users who prefer this approach

Problem Addressed

Previously, a user might find connecting the UI container to a backend service via UI settings would not work. This is because Docker's default bridge network would have prevented the UI from accessing services running on the host's localhost. While it is possible to use a docker run workaround (e.g. --network=host) to allow the UI container to access an NeMo Agent Toolkit server, this is not a production-ready approach due to security.

Testing

  • Verified end-to-end functionality with a fresh Docker Compose deployment
  • Confirmed UI successfully connects to the calculator service
  • Validated all health checks pass correctly
  • Tested startup sequence and container dependencies
  • Ensured all documented commands are accurate and copy-pasteable

Copy link
Collaborator

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the Docker compose file would be better suited in the NeMo Agent Toolkit example. Otherwise this is a great addition.

@edlee123
Copy link
Author

Closing this PR in favor of the PR in the main NeMo-Agent-Toolkit repo: NVIDIA/NeMo-Agent-Toolkit#497.

@edlee123 edlee123 closed this Jul 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants