Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update streaming example #3195

Merged
merged 4 commits into from
Jan 30, 2025
Merged

Update streaming example #3195

merged 4 commits into from
Jan 30, 2025

Conversation

ZiyueXu77
Copy link
Collaborator

Fixes # .

Description

Convert job templates to job API, add end-to-end example with memory comparison, update Readme

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

nvidianz
nvidianz approved these changes Jan 30, 2025
View reviewed changes
Copy link
Collaborator

@nvidianz nvidianz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZiyueXu77
Copy link
Collaborator Author

/build

@ZiyueXu77 ZiyueXu77 enabled auto-merge (squash) January 30, 2025 21:40
@ZiyueXu77 ZiyueXu77 merged commit b26b224 into NVIDIA:main Jan 30, 2025
20 checks passed
@ZiyueXu77 ZiyueXu77 deleted the stream_update branch January 31, 2025 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvidianz nvidianz nvidianz approved these changes

@yanchengnv yanchengnv Awaiting requested review from yanchengnv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZiyueXu77 @nvidianz