Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quant unittest fix #3191

Merged
merged 10 commits into from
Jan 29, 2025
Merged

Quant unittest fix #3191

merged 10 commits into from
Jan 29, 2025

Conversation

ZiyueXu77
Copy link
Collaborator

Fixes # .

Description

Remove quantization unit test, mainly due to limited testable scope and random errors caused by imported but not used packages

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@ZiyueXu77
Copy link
Collaborator Author

/build

@ZiyueXu77 ZiyueXu77 enabled auto-merge (squash) January 29, 2025 22:10
@nvidianz
Copy link
Collaborator

/build

@ZiyueXu77 ZiyueXu77 merged commit b5d7ca6 into NVIDIA:main Jan 29, 2025
20 checks passed
@ZiyueXu77 ZiyueXu77 deleted the unittest_fix branch January 30, 2025 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvidianz nvidianz nvidianz approved these changes

@chesterxgchen chesterxgchen Awaiting requested review from chesterxgchen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZiyueXu77 @nvidianz