Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup Bogus Errors #3190

Merged
merged 8 commits into from
Jan 31, 2025
Merged

Cleanup Bogus Errors #3190

merged 8 commits into from
Jan 31, 2025

Conversation

nvidianz
Copy link
Collaborator

Removed several bogus errors:

  1. Error processing frame: RuntimeError: cannot schedule new futures after shutdown
    This can happen when the message arrives for a cell already being shutdown. Changed it to debug.
  2. Logical Error: Endpoint is already removed
    This is actually not an error. The weak-ref set entry can be removed when the ref is gone. Changed it to debug.
  3. Added name to several threads to help debugging the dangling thread issue.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@nvidianz nvidianz force-pushed the cleanup-f3-bogus-errors branch from fb33777 to 18e63ab Compare January 30, 2025 20:10
@nvidianz
Copy link
Collaborator Author

/build

@nvidianz
Copy link
Collaborator Author

/build

@nvidianz
Copy link
Collaborator Author

/build

@nvidianz nvidianz merged commit f8dd354 into NVIDIA:main Jan 31, 2025
20 checks passed
@nvidianz nvidianz deleted the cleanup-f3-bogus-errors branch January 31, 2025 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants