Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.5] Disable HA CI tests (#3097) #3177

Merged
merged 4 commits into from
Jan 29, 2025

Conversation

YuanTingHsieh
Copy link
Collaborator

Cherry-picking #3097

Description

  • Disable HA tests as the current impl. is obsolete
  • Make master_template consistent (in nvflare/lighter/templates/master_template.yml and
    nvflare/lighter/impl/master_template.yml)

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

### Description
- Disable HA tests as the current impl. is obsolete
- Make master_template consistent (in
nvflare/lighter/templates/master_template.yml and
nvflare/lighter/impl/master_template.yml)

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Quick tests passed locally by running `./runtest.sh`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated.

Co-authored-by: Sean Yang <[email protected]>
@YuanTingHsieh YuanTingHsieh added the cicd continuous integration/continuous development label Jan 23, 2025
@YuanTingHsieh
Copy link
Collaborator Author

/build

Copy link
Collaborator

@SYangster SYangster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YuanTingHsieh
Copy link
Collaborator Author

/build

@YuanTingHsieh YuanTingHsieh merged commit da6e844 into NVIDIA:2.5 Jan 29, 2025
20 checks passed
@YuanTingHsieh YuanTingHsieh deleted the remove_ha_ci_25 branch January 29, 2025 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cicd continuous integration/continuous development
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants