Add ability for clients to send error log to server #3057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/build |
There was a problem hiding this comment.
Thanks!
Changes mostly LGTM, please sync up with @SYangster as I know you both are working on some logging structure.
|
/build |
|
/build |
|
/build |
|
/build |
yanchengnv
requested changes
Nov 20, 2024
|
/build |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renames the error log file to error_log.txt and adds a way to transmit the error logs from clients to the server.
Description
Renames the error log file to error_log.txt and adds a way to transmit the error logs from clients to the server. Currently should_report_error_log is set to False. This can be set to True to test the feature for now, and in the future we will want to add a way to configure this for each site.
On the server, the error log is simply printed, but future PRs will modify this to save the error log in the proper place.
Types of changes
./runtest.sh.