-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the GNN encoding for XGB financial example #3039
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/build |
YuanTingHsieh
approved these changes
Oct 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, great changes, the GNN is for more feature engineering
/build |
YuanTingHsieh
added a commit
to YuanTingHsieh/NVFlare
that referenced
this pull request
Dec 10, 2024
* Readme notebook polish and cleanup * Reorganize folder structure and initial gnn * Complete the graph generate step with edgemap output * Format fix * Format fix * Add graph construction and training notebooks * Add full gnn functionality * Update wording for readme * update the GNN embedding usage --------- Co-authored-by: Chester Chen <[email protected]> Co-authored-by: Yuan-Ting Hsieh (謝沅廷) <[email protected]>
6 tasks
YuanTingHsieh
added a commit
that referenced
this pull request
Dec 10, 2024
* Add GNN encoder and xgb outputs for finance end-to-end example (#2970) * Readme notebook polish and cleanup * Reorganize folder structure and initial gnn * Complete the graph generate step with edgemap output * Format fix * Format fix * Add graph construction and training notebooks * Add full gnn functionality * Update wording for readme --------- Co-authored-by: Chester Chen <[email protected]> * Update the GNN encoding for XGB financial example (#3039) * Readme notebook polish and cleanup * Reorganize folder structure and initial gnn * Complete the graph generate step with edgemap output * Format fix * Format fix * Add graph construction and training notebooks * Add full gnn functionality * Update wording for readme * update the GNN embedding usage --------- Co-authored-by: Chester Chen <[email protected]> Co-authored-by: Yuan-Ting Hsieh (謝沅廷) <[email protected]> * Add XGB explainability output (#3044) * Add XGB explainability output * typo fix * format fix * Update finance end-to-end readme for figure position (#3046) * Update README.md * Update xgboost.ipynb * Fix xgb explanability issue (#3078) * Implement a new algorithm for the CUDA plugin (#3085) * New cuda plugin implementation Signed-off-by: YuanTingHsieh <[email protected]> * Update docstring * Rename CellTable to GHPairArray for clarity and allow max_num_of_gh_pair_per_launch to be customized --------- Signed-off-by: YuanTingHsieh <[email protected]> --------- Signed-off-by: YuanTingHsieh <[email protected]> Co-authored-by: Ziyue Xu <[email protected]> Co-authored-by: Chester Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes previous result where GNN encoding performs worse than raw feature
Description
GNN encoding is supposed to be used as secondary complementary features, rather than by itself, changing the behavior
Types of changes
./runtest.sh
.