Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the GNN encoding for XGB financial example #3039

Merged
merged 15 commits into from
Oct 14, 2024

Conversation

ZiyueXu77
Copy link
Collaborator

Fixes previous result where GNN encoding performs worse than raw feature

Description

GNN encoding is supposed to be used as secondary complementary features, rather than by itself, changing the behavior

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@ZiyueXu77
Copy link
Collaborator Author

/build

Copy link
Collaborator

@YuanTingHsieh YuanTingHsieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great changes, the GNN is for more feature engineering

@YuanTingHsieh
Copy link
Collaborator

/build

@YuanTingHsieh YuanTingHsieh merged commit 3dc385f into NVIDIA:main Oct 14, 2024
20 checks passed
@ZiyueXu77 ZiyueXu77 deleted the gnn_enc branch October 15, 2024 13:55
@ZiyueXu77 ZiyueXu77 restored the gnn_enc branch October 15, 2024 19:44
@ZiyueXu77 ZiyueXu77 deleted the gnn_enc branch October 15, 2024 20:02
YuanTingHsieh added a commit to YuanTingHsieh/NVFlare that referenced this pull request Dec 10, 2024
* Readme notebook polish and cleanup

* Reorganize folder structure and initial gnn

* Complete the graph generate step with edgemap output

* Format fix

* Format fix

* Add graph construction and training notebooks

* Add full gnn functionality

* Update wording for readme

* update the GNN embedding usage

---------

Co-authored-by: Chester Chen <[email protected]>
Co-authored-by: Yuan-Ting Hsieh (謝沅廷) <[email protected]>
@YuanTingHsieh YuanTingHsieh mentioned this pull request Dec 10, 2024
6 tasks
YuanTingHsieh added a commit that referenced this pull request Dec 10, 2024
* Add GNN encoder and xgb outputs for finance end-to-end example (#2970)

* Readme notebook polish and cleanup

* Reorganize folder structure and initial gnn

* Complete the graph generate step with edgemap output

* Format fix

* Format fix

* Add graph construction and training notebooks

* Add full gnn functionality

* Update wording for readme

---------

Co-authored-by: Chester Chen <[email protected]>

* Update the GNN encoding for XGB financial example (#3039)

* Readme notebook polish and cleanup

* Reorganize folder structure and initial gnn

* Complete the graph generate step with edgemap output

* Format fix

* Format fix

* Add graph construction and training notebooks

* Add full gnn functionality

* Update wording for readme

* update the GNN embedding usage

---------

Co-authored-by: Chester Chen <[email protected]>
Co-authored-by: Yuan-Ting Hsieh (謝沅廷) <[email protected]>

* Add XGB explainability output (#3044)

* Add XGB explainability output

* typo fix

* format fix

* Update finance end-to-end readme for figure position (#3046)

* Update README.md

* Update xgboost.ipynb

* Fix xgb explanability issue (#3078)

* Implement a new algorithm for the CUDA plugin (#3085)

* New cuda plugin implementation

Signed-off-by: YuanTingHsieh <[email protected]>

* Update docstring

* Rename CellTable to GHPairArray for clarity and allow max_num_of_gh_pair_per_launch to be customized

---------

Signed-off-by: YuanTingHsieh <[email protected]>

---------

Signed-off-by: YuanTingHsieh <[email protected]>
Co-authored-by: Ziyue Xu <[email protected]>
Co-authored-by: Chester Chen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants