Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add min_responses to send_model_and_wait() #2675

Merged
merged 5 commits into from
Jul 1, 2024
Merged

Add min_responses to send_model_and_wait() #2675

merged 5 commits into from
Jul 1, 2024

Conversation

SYangster
Copy link
Collaborator

@SYangster SYangster commented Jun 27, 2024 •
edited
Loading

#4717625

  • expose min_responses argument in ModelController's send_model_and_wait()
  • hide wait_time_after_min_received argument, set default to 0

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

YuanTingHsieh
YuanTingHsieh previously approved these changes Jun 28, 2024
View reviewed changes
Copy link
Collaborator

@YuanTingHsieh YuanTingHsieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR is good.

chesterxgchen
chesterxgchen requested changes Jun 28, 2024
View reviewed changes
Copy link
Collaborator

@chesterxgchen chesterxgchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should change the default value

@SYangster SYangster requested a review from chesterxgchen July 1, 2024 17:07
chesterxgchen
chesterxgchen previously approved these changes Jul 1, 2024
View reviewed changes
Copy link
Collaborator

@chesterxgchen chesterxgchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SYangster
Copy link
Collaborator Author

/build

@SYangster
Copy link
Collaborator Author

/build

chesterxgchen
chesterxgchen approved these changes Jul 1, 2024
View reviewed changes
Copy link
Collaborator

@chesterxgchen chesterxgchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SYangster SYangster merged commit eac704d into NVIDIA:main Jul 1, 2024
16 checks passed
@SYangster SYangster mentioned this pull request Jul 2, 2024
Merged
6 tasks
nvidianz pushed a commit to nvidianz/NVFlare that referenced this pull request Jul 8, 2024
@SYangster @nvidianz
Add min_responses to send_model_and_wait() (NVIDIA#2675)
8795004 
* expose min_responses, hide wait_time_after_min_received

* change default to None

* add comment
@SYangster SYangster deleted the min_responses branch January 24, 2025 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chesterxgchen chesterxgchen chesterxgchen approved these changes

@YuanTingHsieh YuanTingHsieh YuanTingHsieh left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SYangster @chesterxgchen @YuanTingHsieh