[2.4] Remove ipcl requirement for other training mode except vertical secure #2672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing nvflare plugin
YuanTingHsieh
changed the title
nvflare/app_opt/xgboost/histogram_based_v2/sec/client_handler.py
Outdated
Show resolved
Hide resolved
yanchengnv
requested changes
Jun 27, 2024
nvflare/app_opt/xgboost/histogram_based_v2/sec/client_handler.py
Outdated
Show resolved
Hide resolved
nvflare/app_opt/xgboost/histogram_based_v2/sec/client_handler.py
Outdated
Show resolved
Hide resolved
yanchengnv
requested changes
Jun 27, 2024
yanchengnv
requested changes
Jun 28, 2024
There was a problem hiding this comment.
Very nice!
See my comment about Yuan-Ting's PR #2674, especially the changes to notify_client_done. Make sure that system_panic() is not called multiple times.
If you put all his changes to your PR, then his PR won't be needed.
Please coordinate with YT.
|
/build |
yanchengnv
requested changes
Jun 28, 2024
|
/build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes FLARE-2053
Description
Made changes so ipcl-python package is only required for vertical secure training using nvflare plugin.
Types of changes
./runtest.sh.