Skip to content

Reflect the changes made by #1920 in RL#2780

Merged
tdene merged 3 commits into
NVIDIA:mainfrom
tdene:tde/fix_1920_in_rl
Dec 31, 2025
Merged

Reflect the changes made by #1920 in RL#2780
tdene merged 3 commits into
NVIDIA:mainfrom
tdene:tde/fix_1920_in_rl

Conversation

@tdene

@tdene tdene commented Dec 30, 2025

Copy link
Copy Markdown
Contributor

What does this PR do ?

#1920 made some changes. This also applies them to RL.

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

@tdene tdene requested a review from a team as a code owner December 30, 2025 23:35
@github-actions github-actions Bot requested a review from Phlip79 December 30, 2025 23:36
@tdene tdene enabled auto-merge December 30, 2025 23:36
@ko3n1g ko3n1g added this to the Core 0.16 milestone Dec 30, 2025
@Phlip79 Phlip79 requested a review from jon-barker December 30, 2025 23:37
@Phlip79 Phlip79 added Expert Review [deprecated] Apply this label to indicate that your PR is ready for expert review. complexity: low labels Dec 30, 2025

@jon-barker jon-barker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tdene tdene added this pull request to the merge queue Dec 31, 2025
github-merge-queue Bot pushed a commit that referenced this pull request Dec 31, 2025
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Dec 31, 2025
@tdene tdene added this pull request to the merge queue Dec 31, 2025
Merged via the queue into NVIDIA:main with commit f33e009 Dec 31, 2025
47 checks passed
@tdene tdene deleted the tde/fix_1920_in_rl branch December 31, 2025 15:25
jon-barker pushed a commit to jon-barker/Megatron-LM that referenced this pull request Jan 9, 2026
maanug-nv pushed a commit to maanug-nv/Megatron-LM that referenced this pull request Jan 10, 2026
daiyaanarfeen pushed a commit to daiyaanarfeen/Megatron-LM that referenced this pull request Feb 23, 2026
yangbofun pushed a commit to xlm-research/Megatron-LM that referenced this pull request May 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

complexity: low Expert Review [deprecated] Apply this label to indicate that your PR is ready for expert review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants